Skip to content

feat: declare the SVG kind and drop unread config and translation copies - #82

Merged
imanimanyara merged 3 commits into
mainfrom
feat/svg-kind
Oct 30, 2026
Merged

imanimanyara merged 3 commits into
mainfrom
feat/svg-kind

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Declares this pack's SVG kind in config.json, and removes config and translation copies nothing reads. Data only: no src/ behaviour changes, so it passes against the tagged ichava/core (v0.1.3) and is picked up by core from ichava/core#148 on.

  • config.json: package.kind is icon, the kind core resolves for every category that names none.
  • Removed set.name/set.prefix from the config file, which keeps its one real setting. docs/configuration.md updated.
  • Removed the commands and info translation groups (no pack ships an update command or an about block).
  • Every *_descriptions group matches its label group key for key; nothing needed changing.

Plan rows

Removed: ichava.icon-sets-flag.set.name, ichava.icon-sets-flag.set.prefix, ichava/icon-sets-flag::icons.commands.update, ichava/icon-sets-flag::icons.commands.fetching, ichava/icon-sets-flag::icons.commands.complete, ichava/icon-sets-flag::icons.info.version, ichava/icon-sets-flag::icons.info.total_icons, ichava/icon-sets-flag::icons.info.variant_info.

Verified, kept: ichava.icon-sets-flag.default_variant, ichava/icon-sets-flag::icons.variant_descriptions.4x3, ichava/icon-sets-flag::icons.variant_descriptions.1x1.

Plus the SVG kind rows for packs (gap review, Part 2).

Tests

  • tests/Feature/SvgKindTest.php: pack kind valid, category kinds valid, every declared and on-disk category resolves a kind, the exact illustration categories; and a case that compares with core's own resolution (IconRegistry::kindFor()), skipped with a message when the resolved core predates feat: SVG kind end to end and host-user contracts core#148, which is the tagged v0.1.3 CI resolves today.
  • tests/Feature/RetiredCopiesTest.php: no commands/info lang groups, a non-empty description for every variants/categories/sets label core loads, and the config file holds only its default key.

Both new files fail against main's data (pack kind missing, removed keys present), and pass in full, with no skips, when run against core main in place of the tag.

Local gates: laranail-pint --test, PHPStan at max, pest green.

package.kind is icon, which core resolves for every category that names none. Core reads it from ichava/core#148 on; an older core ignores the key, so this is data only.
Drops the set.name/set.prefix config copies (deleting the config file and its registration where nothing else was left in it) and the commands/info translation groups, written for an update command and an about block no pack ships.
@imanimanyara
imanimanyara merged commit 3b5786a into main Oct 30, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the feat/svg-kind branch October 30, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant