Repository navigation
feat: declare the SVG kind and drop unread config and translation copies - #82
Merged
Merged
Conversation
package.kind is icon, which core resolves for every category that names none. Core reads it from ichava/core#148 on; an older core ignores the key, so this is data only.
Drops the set.name/set.prefix config copies (deleting the config file and its registration where nothing else was left in it) and the commands/info translation groups, written for an update command and an about block no pack ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares this pack's SVG kind in
config.json, and removes config and translation copies nothing reads. Data only: nosrc/behaviour changes, so it passes against the taggedichava/core(v0.1.3) and is picked up by core from ichava/core#148 on.config.json:package.kindisicon, the kind core resolves for every category that names none.set.name/set.prefixfrom the config file, which keeps its one real setting.docs/configuration.mdupdated.commandsandinfotranslation groups (no pack ships an update command or an about block).*_descriptionsgroup matches its label group key for key; nothing needed changing.Plan rows
Removed:
ichava.icon-sets-flag.set.name,ichava.icon-sets-flag.set.prefix,ichava/icon-sets-flag::icons.commands.update,ichava/icon-sets-flag::icons.commands.fetching,ichava/icon-sets-flag::icons.commands.complete,ichava/icon-sets-flag::icons.info.version,ichava/icon-sets-flag::icons.info.total_icons,ichava/icon-sets-flag::icons.info.variant_info.Verified, kept:
ichava.icon-sets-flag.default_variant,ichava/icon-sets-flag::icons.variant_descriptions.4x3,ichava/icon-sets-flag::icons.variant_descriptions.1x1.Plus the SVG kind rows for packs (gap review, Part 2).
Tests
tests/Feature/SvgKindTest.php: pack kind valid, category kinds valid, every declared and on-disk category resolves a kind, the exact illustration categories; and a case that compares with core's own resolution (IconRegistry::kindFor()), skipped with a message when the resolved core predates feat: SVG kind end to end and host-user contracts core#148, which is the tagged v0.1.3 CI resolves today.tests/Feature/RetiredCopiesTest.php: nocommands/infolang groups, a non-empty description for everyvariants/categories/setslabel core loads, and the config file holds only its default key.Both new files fail against
main's data (pack kind missing, removed keys present), and pass in full, with no skips, when run against coremainin place of the tag.Local gates:
laranail-pint --test, PHPStan at max,pestgreen.