Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,14 @@
# Measured on ichava/core#63, a release PR touching only CHANGELOG.md: **0
# checks ran**. The guard could not fire on the one change it exists to guard.
#
# Its own workflow, triggered on the file it reads. Pint and PHPStan keep their
# paths-ignore, since they genuinely have nothing to say about markdown.
# Its own workflow. Since 2026-10-30 no workflow here is path-filtered: every
# check runs on every pull request, so each one can be a required status check
# (a path-filtered check never reports on a pull request it skips).
name: Changelog

on:
pull_request:
branches: [main]
paths:
- 'CHANGELOG.md'
- '.github/workflows/changelog.yml'
workflow_dispatch:

permissions:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: Code Quality
on:
pull_request:
branches: [main]
paths-ignore:
- '**.md'
workflow_dispatch:

concurrency:
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
name: Docs

# `tests.yml` and `code-quality.yml` both carry `paths-ignore: ['**.md']`, so a
# markdown-only pull request runs neither -- and a markdown-only pull request is
# exactly what deletes a docs page. This workflow is the other half of that
# filter: it runs on the changes they skip, and nothing else.
# Checks the shape of the docs/ tree. Like every workflow here since 2026-10-30
# it runs on every pull request: a path-filtered check never reports on a pull
# request it skips, so it could not be a required status check.
on:
pull_request:
branches: [main]
paths:
- '**.md'
- 'tests/Unit/DocsShapeTest.php'
- '.github/workflows/docs.yml'
workflow_dispatch:

concurrency:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: Tests
on:
pull_request:
branches: [main]
paths-ignore:
- '**.md'
workflow_dispatch:

concurrency:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ All notable changes to `ichava/icon-sets-flag` follow [Keep a Changelog](https:/

### Changed

- **Every workflow runs on every pull request.** The `paths-ignore: '**.md'` and `paths:` filters are removed from the `pull_request` triggers, so every check reports on every pull request and can be a required status check on `main`. A path-filtered required check never reports on the pull requests it skips, and blocks them for good.
- **PHPStan analyses at level `max`, up from 0.** `phpstan.neon.dist` now has icon-sets-bundled's shape: one counted, path-scoped ignore for the two `HasIconSetVariants` hooks PHPStan reports as unused because the trait calls them through `static::`, with `reportUnmatchedIgnoredErrors` failing the run if either stops occurring. No baseline, and no source change was needed. `PhpstanLevelTest` reads the config and fails if the level is anything but `max` or a baseline appears.
- **`sync-upstream.yml` commits as the github-actions bot's noreply address** instead of a personal GitHub login, matching packs scaffolded since icon-sets-package-scaffolder#60 and icon-sets-sync's default. The personal-contact guard now also reads `.github/` and `.dev/`.
- **The package author is Simtabi LLC, not a person.** `composer.json` named a personal maintainer and mailbox as author; it now names `Simtabi LLC` with the role address `ichava@simtabi.com` (no personal contact is published, decided 2026-10-28). `NoPersonalContactTest` reads `composer.json`, `README.md`, `LICENSE`, `docs/` and `src/`, fails on a personal name or address, and fails when it reads fewer files than it did when written.
Expand Down
Loading