Repository navigation
Follow core's provider namespace and test kit - #5
Merged
Merged
Conversation
Core moved the pack base provider to Providers\IconPackServiceProvider with no alias at the old name (core C-07, ichava/core#172).
TestCase extends core's Testing\PackTestCase, and the core-only dependency, PHPStan level, sibling constraint, sync caller, workflow permission, stray-text and SVG-policy tests call Testing\PackConformance, keeping their names (P-03, P-04). The copies of each rule's body are gone; core tests each rule passing and failing.
Each where it applied: SECURITY.md rendered from the scaffolder stub (P-09); .gitattributes keeps the hashed licence files byte-stable (P-11); require-dev sorted (P-14); the CI comment says why core's dev-main alias is needed until the re-squash (P-01), and sync-upstream no longer claims Packagist lists the tag (P-02); CONTRIBUTING links the organisation's Code of Conduct, and counts and stale comments match the repository (P-07).
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows ichava/core#172 and #173, one commit per concern.
Simtabi\Laranail\Ichava\Providers\IconPackServiceProvider. The oldSupport\name has no alias, so this is required for the pack to boot against core's main.tests/TestCase.phpextendsTesting\PackTestCase, and the core-only dependency, PHPStan level, sibling constraint, sync caller, workflow permission, stray-text and SVG-policy tests callTesting\PackConformancewith their names unchanged. Each rule is tested passing and failing in core.SECURITY.md(P-09), a.gitattributesrule keeping hashed licence files byte-stable (P-11), sortedrequire-dev(P-14), a CI note on why core'sdev-mainalias is needed until the re-squash (P-01), an accurate sync-upstream comment (P-02), the organisation Code of Conduct link and corrected counts and comments (P-07).No tag; floors move at the re-squash.
Verification
Locally against core
main(composer require "ichava/core:dev-main as 0.1.99",composer.jsonrestored):vendor/bin/pest,vendor/bin/phpstan analyse --debugandcomposer pintall pass.