Repository navigation
State Pepicons' licence per variant and pin it - #4
Merged
Merged
Conversation
All three shipped variants (pop, print, pencil) come from one npm package whose license field names CC BY 4.0, under one repository LICENSE that is the CC BY 4.0 legal code. The root README's request that commercial users buy a licence is in neither, and CC BY 4.0 is irrevocable, so the docs now quote it as a request beside the grant, with the sources read on 2026-11-05.
Fails on a fourth variant, a changed licence text or one that gains a commercial term, a missing per-variant row in ATTRIBUTION.md, or the request being restated as a condition. Proven red by adding a stray variant file and editing the pencil row.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Pepicons licence question: all three shipped variants stay, because every one of them is under an irrevocable CC BY 4.0 grant, and upstream's commercial-use sentence is a request beside that grant, not a term of it.
What upstream says (read 2026-11-05)
CyCraft/pepiconsLICENSE(tagv3.1.6andmain, SHA-256dbb19cb7…b5c5, unchanged since 2021-07-27)pepicons3.1.6licensefieldpackages/pepicons/README.md)Pop!, Print and Pencil (1,275 files each) come from the same package and repository; none has terms of its own.
Changes
ATTRIBUTION.md: a licence-per-variant table, the commercial sentence quoted in full as a request, and why (the grant is irrevocable and has no non-commercial limit; Section 7(b) keeps outside arrangements separate).docs/attribution.md,docs/sets.md, the licencesource.mdandCHANGELOG.mdsay the same.tests/Unit/PepiconsLicenceTest.phpfails on a fourth variant, a changed licence text or one that gains a commercial term, a missing per-variant row, or the request restated as a condition. Proven red by adding a stray variant file and editing the pencil row.The shipped licence file was compared with upstream: byte-identical at
v3.1.6andmain. No SVG, count or recipe changed.Test plan
vendor/bin/pest: 64 passedvendor/bin/phpstan analyse --debug --memory-limit=2G: no errorscomposer pint: passed