Repository navigation
Mark the three hand-supplied set licences with a source.md - #2
Merged
Merged
Conversation
The npm packages for ant-design, eva and pepicons ship no licence file, so a real sync would delete their licence directories. A source.md beside each LICENSE records where the text came from and makes icon-sets-sync's licence sink keep the directory (cbebf08 and later). The sync pin moves to that commit, and SetLicenceTest fails if a marker or a text goes missing.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The npm packages for
ant-design(@ant-design/icons-svg4.6.0),eva(eva-icons1.1.3) andpepicons(3.1.6) ship no licence file, so a real sync would delete theirresources/assets/svg/licenses/<set>/directories and the hand-suppliedLICENSEin each. This PR adds asource.mdbeside each one, recording the upstream file, ref and SHA-256. From ichava/icon-sets-sync#89 (cbebf08) on, each marker makes the licence sink keep its directory and report it ashand-supplied.sync-upstream.ymlmoves both thesync-pack.ymlpin andtoolkit-reffrom06b17d7tocbebf086fc3399faec97ce590c47fcbd535425c3. The only change between those commits is the lowercase marker support.SetLicenceTestexpectsLICENSEandsource.mdin the three directories. A new test requires each marker (exact name fromscandir) and itsLICENSE, and checks that the marker carries the text's SHA-256. Removing a marker, removing a licence, and renaming a marker toSOURCE.mdeach failed it.Dry run
recipe icon-sets-extras.{ant-design,eva,pepicons} --dry-run, with a binary built fromcbebf08against this checkout:status: hand-suppliedwith no warning.Local gates: pest passes (56, 1 skipped),
phpstan --debugreports no errors, andcomposer pintpasses.