Skip to content

Mark the three hand-supplied set licences with a source.md - #2

Merged
imanimanyara merged 2 commits into
mainfrom
chore/licence-source-marker
Nov 5, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
chore/licence-source-marker

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

The npm packages for ant-design (@ant-design/icons-svg 4.6.0), eva (eva-icons 1.1.3) and pepicons (3.1.6) ship no licence file, so a real sync would delete their resources/assets/svg/licenses/<set>/ directories and the hand-supplied LICENSE in each. This PR adds a source.md beside each one, recording the upstream file, ref and SHA-256. From ichava/icon-sets-sync#89 (cbebf08) on, each marker makes the licence sink keep its directory and report it as hand-supplied.

  • sync-upstream.yml moves both the sync-pack.yml pin and toolkit-ref from 06b17d7 to cbebf086fc3399faec97ce590c47fcbd535425c3. The only change between those commits is the lowercase marker support.
  • SetLicenceTest expects LICENSE and source.md in the three directories. A new test requires each marker (exact name from scandir) and its LICENSE, and checks that the marker carries the text's SHA-256. Removing a marker, removing a licence, and renaming a marker to SOURCE.md each failed it.

Dry run

recipe icon-sets-extras.{ant-design,eva,pepicons} --dry-run, with a binary built from cbebf08 against this checkout:

  • 0 added, 0 removed and 0 changed in each set (848, 490 and 3,825 SVGs).
  • Each licence reports status: hand-supplied with no warning.
  • The checkout was unchanged afterwards.

Local gates: pest passes (56, 1 skipped), phpstan --debug reports no errors, and composer pint passes.

The npm packages for ant-design, eva and pepicons ship no licence file, so
a real sync would delete their licence directories. A source.md beside
each LICENSE records where the text came from and makes icon-sets-sync's
licence sink keep the directory (cbebf08 and later). The sync pin moves to
that commit, and SetLicenceTest fails if a marker or a text goes missing.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 01:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit ee1650b into main Nov 5, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the chore/licence-source-marker branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants