Repository navigation
Sync on icon-sets-sync 06b17d7 and match licence files to what a sync writes - #1
Merged
Merged
Conversation
Moves the reusable sync-pack.yml pin and toolkit-ref together to 06b17d7, the merge of icon-sets-sync#88, which adds this pack's recipe. sync-pack.yml's inputs are unchanged between the old pin and the new one, so the caller's with: block stays as it is.
icon-sets-sync's licence sink deletes resources/assets/svg/licenses/<set>/ and writes upstream's licence files back under their upstream names on every real sync (icon-sets-sync#88). Four sets' files had been renamed to LICENSE and are back under upstream's names (game-icons license.txt, garden and siemens-ix LICENSE.md, svg-logos LICENSE.txt), bytes unchanged. Noto Emoji's full Apache-2.0 text, which upstream does not ship, moves to resources/assets/svg/pack-licenses/noto-emoji/ so the first sync does not delete it. SetLicenceTest now reads each licence through license.file and asserts each directory's exact file list, as a dry run of each recipe reports it.
The recipe fetches and stamps website@0.0.17, the radix-ui/icons archive tag; the pack recorded 1.3.2, the packages/radix-icons version inside it, so the sync would have compared the wrong number with upstream's tags and rewritten the field on its first run. ref still names 1.3.2. update_command's note, which said the pack had no recipe, now names the per-set icon-sets-extras.<set> recipes.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
sync-upstream.yml's reusablesync-pack.ymlpin andtoolkit-reftogether to icon-sets-sync06b17d7(ichava/icon-sets-sync#88: recipes for the v0.1.0 packs,split-variants,exclude, andlicence_sha256pins).sync-pack.yml's inputs did not change between the old pin and06b17d7(the only diff is a comment), so the caller'swith:block is untouched.game-icons/license.txt,garden/LICENSE.md,siemens-ix/LICENSE.md,svg-logos/LICENSE.txt.resources/assets/svg/pack-licenses/noto-emoji/LICENSE-2.0.txt; inlicenses/noto-emoji/the first sync would have deleted it.SetLicenceTestreads each licence throughlicense.fileand asserts each licence directory's exact file list (proven red by renaming one back).0.0.17, thewebsite@0.0.17tag the recipe fetches and stamps, atupstream.sets.radix-icons.current_version(refstill names1.3.2).SOURCE.mdmarkers forant-design,evaandpepicons. The sink matchesSOURCE.mdexactly and thesim-standardspre-commit hook refuses an uppercase Markdown name, so those three directories are still deleted by a real sync until that is decided.Verification
Local gates: pest,
phpstan --debug, pint all pass.icon-sets-sync recipe <pack> --dry-run, binary built from06b17d7, against this branch: