Skip to content

Sync on icon-sets-sync 06b17d7 and match licence files to what a sync writes - #1

Merged
imanimanyara merged 3 commits into
mainfrom
chore/sync-pin-06b17d7
Nov 5, 2026
Merged

imanimanyara merged 3 commits into
mainfrom
chore/sync-pin-06b17d7

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Moves sync-upstream.yml's reusable sync-pack.yml pin and toolkit-ref together to icon-sets-sync 06b17d7 (ichava/icon-sets-sync#88: recipes for the v0.1.0 packs, split-variants, exclude, and licence_sha256 pins). sync-pack.yml's inputs did not change between the old pin and 06b17d7 (the only diff is a comment), so the caller's with: block is untouched.

  • Four licence files go back to upstream's names, bytes unchanged: game-icons/license.txt, garden/LICENSE.md, siemens-ix/LICENSE.md, svg-logos/LICENSE.txt.
  • Noto Emoji's full Apache-2.0 text, which upstream does not ship, moves to resources/assets/svg/pack-licenses/noto-emoji/LICENSE-2.0.txt; in licenses/noto-emoji/ the first sync would have deleted it.
  • SetLicenceTest reads each licence through license.file and asserts each licence directory's exact file list (proven red by renaming one back).
  • Radix Icons records 0.0.17, the website@0.0.17 tag the recipe fetches and stamps, at upstream.sets.radix-icons.current_version (ref still names 1.3.2).
  • Not here: the SOURCE.md markers for ant-design, eva and pepicons. The sink matches SOURCE.md exactly and the sim-standards pre-commit hook refuses an uppercase Markdown name, so those three directories are still deleted by a real sync until that is decided.

Verification

Local gates: pest, phpstan --debug, pint all pass.

icon-sets-sync recipe <pack> --dry-run, binary built from 06b17d7, against this branch:

icon-sets-extras.ant-design exit=0  added=0 removed=0 changed=0   upstream ships none; hand-supplied
icon-sets-extras.boxicons exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.coolicons exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.coreui exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.devicon exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.eva exit=0  added=0 removed=0 changed=0   upstream ships none; recorded
icon-sets-extras.feather exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.fluent-emoji exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.game-icons exit=0  added=0 removed=0 changed=0  would_write=[license.txt]
icon-sets-extras.garden exit=0  added=0 removed=0 changed=0  would_write=[LICENSE.md]
icon-sets-extras.health-icons exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.iconpark exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.mingcute exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.noto-emoji exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.pepicons exit=0  added=0 removed=0 changed=0   upstream ships none; recorded
icon-sets-extras.pinhead exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.radix-icons exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]
icon-sets-extras.siemens-ix exit=0  added=0 removed=0 changed=0  would_write=[LICENSE.md]
icon-sets-extras.svg-logos exit=0  added=0 removed=0 changed=0  would_write=[LICENSE.txt]
icon-sets-extras.tdesign exit=0  added=0 removed=0 changed=0  would_write=[LICENSE]

Moves the reusable sync-pack.yml pin and toolkit-ref together to 06b17d7, the merge of icon-sets-sync#88, which adds this pack's recipe. sync-pack.yml's inputs are unchanged between the old pin and the new one, so the caller's with: block stays as it is.
icon-sets-sync's licence sink deletes resources/assets/svg/licenses/<set>/ and writes upstream's licence files back under their upstream names on every real sync (icon-sets-sync#88). Four sets' files had been renamed to LICENSE and are back under upstream's names (game-icons license.txt, garden and siemens-ix LICENSE.md, svg-logos LICENSE.txt), bytes unchanged. Noto Emoji's full Apache-2.0 text, which upstream does not ship, moves to resources/assets/svg/pack-licenses/noto-emoji/ so the first sync does not delete it. SetLicenceTest now reads each licence through license.file and asserts each directory's exact file list, as a dry run of each recipe reports it.
The recipe fetches and stamps website@0.0.17, the radix-ui/icons archive tag; the pack recorded 1.3.2, the packages/radix-icons version inside it, so the sync would have compared the wrong number with upstream's tags and rewritten the field on its first run. ref still names 1.3.2. update_command's note, which said the pack had no recipe, now names the per-set icon-sets-extras.<set> recipes.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit 30cf080 into main Nov 5, 2026
8 checks passed
@imanimanyara
imanimanyara deleted the chore/sync-pin-06b17d7 branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants