Skip to content

Remove the deprecated vendored build and kernel re-exports - #146

Merged
imanimanyara merged 1 commit into
mainfrom
chore/retire-deprecated-browser-pieces
Nov 13, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/retire-deprecated-browser-pieces

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

  • Removes resources/vendor/react-icon-browser (254 files), build:lib, sync:react-icon-browser, check:consumers, the library-build checks behind them and vendoredLibrary.test.ts. Nothing imported any of it.
  • Wires in the one live file: the prepaint component now inlines resources/views/prepaint.html, written by npm run build:prepaint.
  • Removes the ten re-export files for the kernel's shared pieces; 40 files import @ichava/js-ui-kernel/react directly and noDeprecations.test.ts allows no exceptions.
  • inertia-app.css rebuilt: Tailwind no longer scans the old bundle (181 to 172 KB, only utilities nothing in the source names).
  • Keeps .dev/imported/react-icon-browser/ for the e2e port and the shared sync-vendored-library.mjs (config-drift copy, used by ichava.com's landing build).

Verification

  • typecheck:inertia, lint: clean
  • Vitest: 135 files, 993 passed, 3 skipped
  • Pest --filter=Prepaint: 5 passed
  • build:prod: only inertia-app.css changed, committed

The vendored react-icon-browser build, its scripts and checks were
deprecated in 3e and nothing imported them. Its one live file,
prepaint.html, moves to resources/views/ and build:prepaint writes it
there. The ten re-export files go too: every caller imports
@ichava/js-ui-kernel/react directly.
Copilot AI balanced review requested due to automatic review settings November 13, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit f1372ee into main Nov 13, 2026
15 checks passed
@imanimanyara
imanimanyara deleted the chore/retire-deprecated-browser-pieces branch November 13, 2026 12:08
imanimanyara added a commit that referenced this pull request Nov 13, 2026
The hold below 5.1.0 existed for check:public-api, which went with the
library build in #146. Built from a fresh install, as the committed
build check does.
imanimanyara added a commit that referenced this pull request Nov 13, 2026
* chore(deps)(deps): bump zustand from 5.0.16 to 5.1.0

Bumps [zustand](https://github.com/pmndrs/zustand) from 5.0.16 to 5.1.0.
- [Release notes](https://github.com/pmndrs/zustand/releases)
- [Commits](pmndrs/zustand@v5.0.16...v5.1.0)

---
updated-dependencies:
- dependency-name: zustand
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Rebuild the bundle for zustand 5.1.0

The hold below 5.1.0 existed for check:public-api, which went with the
library build in #146. Built from a fresh install, as the committed
build check does.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Imani Manyara <imanimanyara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants