Repository navigation
Check the Inertia props; vendor react-icon-browser 6217b2b - #138
Merged
Merged
Conversation
snapshotFromProps checks icons, pagination, packages and appliedFilters for the shapes the browser reads, and a malformed prop rejects the visit.
Lazy locale catalogs, GridList library rows and declared window globals.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshotFromPropsreplacespage.props as unknown as Partial<BrowserSnapshot>:icons,pagination,packagesandappliedFiltersare checked for the shapes the browser reads, a partial reload keeps only what it carries, and a malformed prop rejects the visit.snapshotProps.test.ts(red first: missing export, 8 failures).6217b2b(react-icon-browser#211), built from a fresh clone: lazy locale catalogs (F-12), GridList library rows (F-20), declared window globals. Page first load (entry plus its static chunks): 1,411,528 B / 408,868 gzip before, 1,289,667 B / 380,135 gzip after.Locally: 407 Pest tests, typecheck, ESLint, 115 Vitest tests,
build:prod.