Repository navigation
Re-audit fixes: installed-pack default, page chunks, query service, FormRequests, vendor-named middleware - #137
Merged
Merged
Conversation
- browserConfig passes the page's packages (core's registered packs) as defaults.packages (Q42). - Inertia pages load lazily, chunk names carry their hash (F-12). - check:config-drift compares eslint.base.js and the .dev/tools scripts with js-ui-kernel (F-18).
…ndor-named middleware - F-08: PackageDetails + PackageDetailsData serve both controllers; IconTables names core's tables once. - F-09: four FormRequests with toData() DTOs replace six inline rule sets. - F-10: SecurityNonce, AuditLogger, HostUser, IconSnippets and the Translator are injected. - F-11: middleware aliases and groups are ichava-icon-browser.*, forward only. HttpLayerConventionsTest guards all four.
The library names no pack and opens on the installed ones (Q42), loads its on-demand layers as chunks, and links the generator's docs for the native exports. The page bundle splits per Inertia page.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…switch, morph alias - Type-hint ChecksPackUpdates and DatabaseOperations. - Register Blade components as ichava-icon-browser::*, never under core's short prefix; a test boots a host with it off. - Read core's components.test_icons; drop test_component_enabled. - The terms hierarchy reads Icon::getMorphClass(), not 'icon'. - Document running migrations after an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-audit 2026-11-05 work, with react-icon-browser vendored at
959b07c(built from a fresh clone).browserConfigpasses the Inertia page'spackages(core's registered packs) asdefaults.packages; the vendored library carries no pack list. Red first:appConfig.test.ts.?v=;npm run cleanremoves them. Before: one 1,497,224 B file (428,454 gzip). After: 1,411,528 B (408,868 gzip) on first load plus the visited page's own chunk.PackageDetails, returns aPackageDetailsDataboth package-detail actions render;IconTablesnames core's tables once.toData()DTOs replace six inline rule sets; JSON callers keep the API's validation body.CreateCollection::rules()removed (forward only).app().ichava-icon-browser.*, forward only. Theichava.adminGate ability keeps its name.check:config-drift(in CI) compares the shared files with js-ui-kernel.HttpLayerConventionsTestguards F-08 to F-11 (red first: 5 failures). Locally: 404 Pest tests, PHPStan, Pint, typecheck, ESLint, 107 Vitest tests,build:prod.