Repository navigation
Name icon-browser where docs and comments named react-icon-browser - #183
Merged
Merged
Conversation
react-icon-browser is retired; the browser that shares core's SVG caps and monochrome rule, and its svg-baseline spec, live in icon-browser since react consolidation 3d. The config comment, constants, docs, the architecture diagram and two test notes now say so. Comments only: no value or behaviour changes, and CHANGELOG history is unchanged.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React consolidation row 5.1. react-icon-browser and react-landingpage are retired (owner, 2026-11-11); their source lives in
ichava/icon-browser(resources/js) andichava/ichava.com(src/resources/js/landing) since react consolidation 3d.config/ichava-core.php,IchavaConstants,docs/configuration.md) and the monochrome rule (ConvertsMonochromeToCurrentColor) said they match react-icon-browser; they now name icon-browser's browser (resources/js/modules/svg/infrastructure/monochrome.tsfor the latter).docs/architecture.md's diagram shows react-icon-browser as retired and folded into icon-browser.SvgArchetypeRegressionTestpoints aticon-browser/e2e/browser/svg-baseline.spec.ts(public packs only);SvgPresentationParityTestnames icon-browser among the copies of the presentation vectors.Comments that record where code moved from, and CHANGELOG history, are left as written. No deprecations.
Verification
vendor/bin/pest tests/Unit/SvgPresentationParityTest.php tests/Unit/SvgArchetypeRegressionTest.php: 22 passed.laranail-pint --teston the five touched PHP files: passed.