Repository navigation
Update the installation guide's pack table in the catalogue sync - #180
Merged
Merged
Conversation
bin/sync-icon-sets.php rewrote icon-sets.json alone, so a count change opened a pull request InstallationPackTableTest failed (#179). The script now sets each table row's count from the catalogue it writes, and the workflow commits both files.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly catalogue sync rewrote
icon-sets.jsonalone, so any count change opened a pull request thatInstallationPackTableTestfailed. That's why #179 is red: it moves tabler to 6,287 and openmoji to 8,990, whiledocs/installation.mdstill says 6,257 and 8,568.bin/sync-icon-sets.phpnow sets each pack-table row's count indocs/installation.mdfrom the catalogue it just wrote (withPackTableCounts()). Rows, order and repositories are left as written, so a set added or removed still fails the table test instead of being papered over.sync-icon-sets.ymlcommits both files.tests/Unit/SyncIconSetsDocTableTest.php: row counts are set, an unnamed row and the surrounding prose are untouched, and the real guide agrees with the real catalogue. Proven red by making the replacement a no-op.Checked
icon-sets.jsonlocally: the helper changed exactly the tabler and openmoji rows, andInstallationPackTableTestpassed.Once this merges, the next nightly run rewrites #179's branch with both files.