Repository navigation
docs: sync icon-sets catalog - #176
Merged
Merged
Conversation
bin/sync-icon-sets.php reads every pack at its latest release tag. icon-sets-twemoji's v0.1.0 still carries the OpenMoji sets that its default branch dropped, so the nightly sync proposed 10,567 "Emoji Sets" back over the recorded 3,435 "Twemoji" (#176), and InstallationPackTableTest and the install characterization test caught it. A set may now carry a hold naming a tag and its commit; while that tag is still the latest release at that commit the set keeps its snapshot, and the hold drops itself once a newer tag is cut or the tag moves.
Restores the twemoji entry the sync replaced with v0.1.0's pre-split bundle (title, description, licence and count back to the Twemoji-only 3,435 that docs/installation.md lists) and records the hold, so the next sync keeps them until icon-sets-twemoji tags a release that matches its branch. Re-running the sync with the fixed script reports the catalogue unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated refresh of icon-sets.json, corrected.
The sync read icon-sets-twemoji at its latest tag, v0.1.0, which still holds the OpenMoji sets the branch dropped, so it proposed 10,567 "Emoji Sets" over the recorded 3,435 "Twemoji". InstallationPackTableTest and the install characterization test caught it.