Repository navigation
Name the Twemoji pack ichava/icon-sets-twemoji - #175
Merged
Merged
Conversation
The emoji pack ships Twemoji only and was renamed, forward only. The catalogue entry takes key twemoji, the new package, repository and title; docs, diagrams, comments and the registration golden fixture follow. Stored ids under the old name stop resolving and hosts re-seed. NoFormerTwemojiPackNameTest fails if the old name returns outside CHANGELOG.md and the estate-wide changelog.yml comment; proven red.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The emoji pack ships Twemoji only and is renamed to
ichava/icon-sets-twemoji(ichava/icon-sets-twemoji#103), forward only.icon-sets.json: keytwemoji(wasemoji), package/repositoryichava/icon-sets-twemoji, titleTwemoji; the OpenMoji description follows that pack'sconfig.json.InstallationPackTableTest), architecture diagrams, pack-docs link,check-updatesexample.JsonConfigConstants,IconPackUpdateAvailable,SvgProcessingService,PackConfigShapeTest.RegistrationGolden/twemojiwith the pack's currentconfig.json; regenerated, the diff is that pack's name, title, prefix, description and repository plus the OpenMoji description.[Unreleased]).Guard
tests/Unit/NoFormerTwemojiPackNameTest.phpfails if the old name appears outsideCHANGELOG.mdand the estate-widechangelog.ymlcomment, with a file floor, and pins the catalogue key. Proven red on a planted line indocs/installation.md.Test plan
vendor/bin/pest --parallel: 1088 passed, 10 skippedphpstan --debug --memory-limit=2G: no errorscomposer pint: passed