Repository navigation
Resolve the cache store on use, so packs boot - #173
Merged
Merged
Conversation
A pack's constants class reads its config while the providers register, before the cache store exists, and PackConfigCache resolved the store at construction, so every pack failed to boot against #172. It now resolves the store when it reads or forgets, and a failure falls back to the file. A test lists a pack provider with the application, which core's other pack tests did not.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every pack failed to boot against #172 with
Target class [cache] does not exist. A pack's constants class reads its config while the providers register, before the cache store exists, andPackConfigCacheresolved the store at construction. It now resolves the store when it reads or forgets, falling back to the file on failure.Core's pack tests registered their fixture after boot, which is why none caught it.
PackBootsInProviderListTestlists the fixture with the application; it failed with the same error before the fix.Verification
vendor/bin/pest: 1070 passed, 10 skipped.--debug: no errors.composer pint: passed.