Repository navigation
Catalog icon-sets-openmoji and count emoji as Twemoji only - #171
Merged
Merged
Conversation
icon-sets.json gains the openmoji set (8,568) and emoji's count, description and licence follow icon-sets-emoji#99 (3,435). docs/installation.md's pack table follows. By hand: the sync script counts at the latest tag, and emoji's v0.1.0 still holds OpenMoji.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icon-sets.jsongainsichava/icon-sets-openmoji(8,568 icons,variants: [default],latest_version: nullsince the pack has no tag yet), and the emoji set's count (3,435), description and licence follow icon-sets-emoji#99, which moved OpenMoji out.docs/installation.md's pack table adds the openmoji row and the new emoji count (InstallationPackTableTest).Edited by hand in the script's exact shape.
bin/sync-icon-sets.phpcounts each pack at its latestvX.Y.Ztag, and emoji'sv0.1.0still carries the OpenMoji sets, so running it would put back 10,567. Until emoji is re-tagged at the release re-squash, the nightlysync-icon-setspull request will propose that old count; it should not be merged before then.ichava.com's landing copy and
LandingCountsTestmove to these figures next (18,783 = 6,238 + 542 + 3,435 + 8,568).Verification
pest 982 passed (10 skipped), phpstan (
--debug --memory-limit=2G) no errors,composer pintpassed.