Repository navigation
Remove package.replaces set aliasing - #170
Merged
Merged
Conversation
It existed only so icon-sets-emoji's openmoji-* ids kept resolving after OpenMoji moved to icon-sets-openmoji. The owner removed the emoji copies, so nothing declares it. Removes PackAliases, the replaces and deprecated marker readers, canonicalId/isReplaced/packAliases, the deprecation log method, the seeder and watcher skips, and doctor's alias checks.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes moving a set between packs (
package.replaces, D9). It existed only soichava/icon-sets-emoji::openmoji-*ids kept resolving after OpenMoji moved toichava/icon-sets-openmoji. The owner decided to remove the emoji copies (forward-only), so nothing declares it any more.Removed:
Support\PackAliases,PackConfigData::replaces()anddeprecatedCategories().IconRegistry::canonicalId(),isReplaced(),packAliases()and the rewrite at the four places an id is parsed.Ichava::canonicalId()and its facade docblock entry.IchavaLogger::deprecation(), whose only caller was the rewrite.alias.deprecated_idsandalias.replacement_missing, their lang keys and the scan helpers only they used.PackAliasTestand its four fixtures.docs/kinds.mdsection that described all of the above.Callers measured across every file in
ichava/packagesandichava/demos(3,643 files; positive controlPackConfigData::found, negative control 0). Outside core, only icon-sets-emoji'sOpenmojiDeprecationTestand icon-sets-openmoji'sReplacesEmojiTestcall any of it, and both are removed in the follow-up PRs to those packs. icon-browser, react-icon-browser, ichava.com and js-icon-components call none of it.PackConfigShapeTestnow asserts registry metadata has noreplacesordeprecated_categoriesand thatPackAliasesandcanonicalId()are gone (proven red by restoringPackAliases.php).Gates: Pest 982 passed, 10 skipped; PHPStan no errors; Pint passed.