Skip to content

Storybook#138

Draft
ciaranschutte wants to merge 11 commits into
v4from
storybook
Draft

Storybook#138
ciaranschutte wants to merge 11 commits into
v4from
storybook

Conversation

@ciaranschutte
Copy link
Copy Markdown
Contributor

@ciaranschutte ciaranschutte commented Jan 14, 2024

Description of changes

  • upgrades storybook
  • changes storybook to work with vite instead of webpack
  • renames stories
    • Icon/stories.tsx => Icon/Icon.stories.tsx (better IDE experience)
  • updates stories to CSF format for "component driven development" (storiesOf format not supported in v7)

Type of Change

  • Bug
  • Styling
  • New Feature

Checklist before requesting review:

  • Design (select one):
    • Matches design:
      • component sizes, spacing, and styles
      • font size, weight, colour
      • spelling has been double checked
    • No design provided, screenshot of changes included in PR
    • No changes to UI
  • UI Kit (select one):
    • New Components with storybook stories created
    • Modified Existing components and updates stories
    • No new UIKit components or changes
  • Feature is minimally responsive
  • Manual testing of UI feature
  • Add copyrights to new files
  • Connected ticket to PR

@ciaranschutte
Copy link
Copy Markdown
Contributor Author

Screenshot 2024-01-14 at 4 14 07 PM

@ciaranschutte ciaranschutte changed the base branch from feat/v4_build_pipeline to v4 January 25, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant