fix: resolve MantineStyleProp function/array values for table style - #840
Open
Rawi2115 wants to merge 1 commit into
Open
fix: resolve MantineStyleProp function/array values for table style#840Rawi2115 wants to merge 1 commit into
Rawi2115 wants to merge 1 commit into
Conversation
The table's style prop was built via object-spread of styles?.table, which silently drops function values (functions have no enumerable own properties) and mishandles arrays (spreading an array into an object produces numeric keys, not valid CSS), causing a runtime TypeError when an array was passed. Pass style as an array instead, matching the pattern already used for the root Box, so Mantine's built-in style resolver correctly handles CSSProperties, functions, and arrays per MantineStyleProp. Fixes icflorescu#835
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table's style prop was built via object-spread of styles?.table, which silently drops function values (functions have no enumerable own properties) and mishandles arrays (spreading an array into an object produces numeric keys, not valid CSS), causing a runtime TypeError when an array was passed.
Pass style as an array instead, matching the pattern already used for the root Box, so Mantine's built-in style resolver correctly handles CSSProperties, functions, and arrays per MantineStyleProp.
Verified with the repro cases from the issue:
table: () => ({ color: 'red' })— now renders red (was previously ignored)table: [{ color: 'red' }]— now renders red with no runtime error (previously threwTypeError: Failed to set an indexed property [0] on 'CSSStyleDeclaration')table: { color: 'red' }— still works as before (no regression)Fixes #835