Skip to content

Repair TravelAuth Guidance References - #396

Draft
klondikemarlen wants to merge 2 commits into
mainfrom
issue-395-guidance-audit-cleanup
Draft

klondikemarlen wants to merge 2 commits into
mainfrom
issue-395-guidance-audit-cleanup

Conversation

@klondikemarlen

@klondikemarlen klondikemarlen commented Jul 14, 2026

Copy link
Copy Markdown
Member

Related Links

Closes #395

Related shared guidance removal: klondikemarlen/marlens-skills-rules-and-tools#124

Context

The earlier cleanup added a hand-maintained guidance ledger. The upstream template was removed because it had no audit consumer and could drift from the local guidance it duplicated.

Implementation

  • Retain the stale-link and inventory cleanup from Repair Stale Agent Workflow References #395.
  • Remove agents/guidance-ledger.yml; intentional local guidance remains beside the files it governs.
  • Keep TravelAuth-specific commands, routes, UI labels, authentication, and deployment guidance local.

Screenshots

N/A — documentation and guidance-only change.

Learner Coverage

No action — #395 was manually filed and contains no evidence of a missed recurring OMP Learner signal or capability gap.

Review and QA Evidence

  • Self-review: PASS — reviewed the complete 8-file diff; no findings.
  • Guidance audit: PASS — node /home/marlen/code/klondikemarlen/marlens-skills-rules-and-tools/bin/agent-guidance-audit.js --json --strict . returned [].
  • Whitespace: PASS — git diff --check origin/main...HEAD produced no output.

Testing Instructions

  1. Run node /home/marlen/code/klondikemarlen/marlens-skills-rules-and-tools/bin/agent-guidance-audit.js --json --strict . from this branch.
  2. Confirm the output is [].
  3. Run git diff --check origin/main...HEAD.
  4. Confirm agents/guidance-ledger.yml is absent and local override rationale remains in the affected local guidance.

Merge Gate

BLOCKED — requires non-author review.

Fix stale workflow, template, and docs links, remove a stale static workflow inventory, and add an informational shared-guidance ledger.
@klondikemarlen

Copy link
Copy Markdown
Member Author

Self-review: no findings.

Checked #395 acceptance criteria:

  • stale workflow/template/example path references are fixed or removed;
  • stale hand-maintained workflow inventory is removed in favor of workflow indexes;
  • agents/guidance-ledger.yml records local overrides and TravelAuth-specific guidance boundaries;
  • project-specific commands, routes, UI labels, and domain guidance remain local;
  • strict shared audit returns [].

@klondikemarlen
klondikemarlen marked this pull request as ready for review July 14, 2026 15:13
@klondikemarlen
klondikemarlen marked this pull request as draft July 16, 2026 03:33
Removes the unsupported ledger so local override rationale stays beside the guidance it governs.
@klondikemarlen

Copy link
Copy Markdown
Member Author

Scope Correction and Follow-up Review

klondikemarlen/marlens-skills-rules-and-tools#124 removed the unsupported guidance-ledger template. This PR now removes the previously added agents/guidance-ledger.yml; no replacement inventory is required.

  • Complete-diff self-review: PASS — no findings.
  • node /home/marlen/code/klondikemarlen/marlens-skills-rules-and-tools/bin/agent-guidance-audit.js --json --strict .: PASS ([]).
  • git diff --check origin/main...HEAD: PASS (no output).

The PR remains draft and BLOCKED pending required non-author review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

Repair Stale Agent Workflow References

1 participant