TK-32: Preserve Documents and Knowledge Items When Reverting an ISA to Draft - #71
Merged
Conversation
Reverting a signed agreement previously wiped the uploaded signed documents and was blocked entirely once knowledge items were linked, so amendments lost work. - Keep the signed documents and any linked knowledge items on revert to draft; only the groups and their access grants are removed, as before. - Allow reverting to draft even when knowledge items are linked (policy and UI). - Show the upload date and time on each signed document. - Update the revert-to-draft confirmation copy to reflect what is kept. See https://yg-hpw.atlassian.net/browse/TK-32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://yg-hpw.atlassian.net/browse/TK-32
Context
Amending a signed Information Sharing Agreement lost work:
Reverting a signed agreement to draft deleted the uploaded signed documents, and the action was hidden/blocked entirely once a knowledge item was linked. Signed documents also showed only a date, not a time.
Several acceptance criteria were already met and are unchanged: the downloadable Word agreement is generated on demand from the latest saved data (so edits are always reflected), draft agreements already offer "Mark as Signed" to upload the signed version with the same options as the first time, and reverting still removes the agreement's groups.
Implementation
Screenshots
TODO - signed documents timestamp and the updated revert-to-draft dialog.
Testing Instructions
dev test.dev up.