Skip to content

TK-65: ISA changes - #66

Merged
burkkyy merged 2 commits into
mainfrom
tk-65/isa-changes
Sep 4, 2026
Merged

TK-65: ISA changes#66
burkkyy merged 2 commits into
mainfrom
tk-65/isa-changes

Conversation

@burkkyy

@burkkyy burkkyy commented Sep 4, 2026

Copy link
Copy Markdown
Member

Fixes https://yg-hpw.atlassian.net/browse/TK-65

Changes

  • ISA Title label: Renamed the title field label from "Agreement Title"/"Title" to "ISA Title" in both the view card (InformationSharingAgreementBasicInformationCard.vue) and the edit card (InformationSharingAgreementBasicInformationEditCard.vue).
  • Naming-format hint: Added a persistent hint on the title input in the new/edit ISA form guiding the required format FNG-YG Department Acronym-Project/Purpose-YYYY-YYYY (e.g. KDFN-HPW-Whitehorse Generating Station-2026-2029).

Screenshoots

2026-09-04_14-52 correct

Testing Instructions

  1. Run the test suite via dev test.
  2. Boot the app via dev up.
  3. Log in to the app at http://localhost:3000.

Test Case 1: New ISA form shows the "ISA Title" label and format hint

  1. Click Sharing Agreements in the left sidebar nav.
  2. Click the New Agreement button (top right of the list page).
  3. On the Basic Information card, locate the title field and verify:
  • The field label reads **ISA Title *** (not "Title" or "Agreement Title").
  • A persistent hint is shown beneath it: Format: FNG-YG Department Acronym-Project/Purpose-YYYY-YYYY (e.g. KDFN-HPW-Whitehorse Generating Station-2026-2029).

Test Case 2: Non-matching title shows a non-blocking warning (still saves)

  1. In the ISA Title field, type a title that does not match the format, e.g. Some random title.
  2. Verify a warning alert (amber, tonal) appears directly below the field: Title does not match the recommended format: FNG-YG Department Acronym-Project/Purpose-YYYY-YYYY (e.g.
    KDFN-HPW-Whitehorse Generating Station-2026-2029).
  3. Fill in the remaining required fields:
  • **What is the purpose, work, program, decision, or project this Traditional Knowledge (TK) will inform? ***: enter any text.
  • **Yukon First Nation or Indigenous Government Contact Name ***: select a contact.
  • **Yukon First Nation or Indigenous Government Contact Title ***: enter any text.
  • **Yukon Government (YG) Contact Name ***: select a contact.
  • **Yukon Government (YG) Contact Title ***: enter any text.
  1. Click the Create button.
  2. Verify creation succeeds despite the warning — success message Information Sharing Agreement created. appears and you are redirected to the Agreement Duration & Expiration edit step.
    This confirms the warning is non-blocking.

Test Case 3: Matching title clears the warning (dashes allowed in Project/Purpose)

  1. Start a new ISA again (Sharing Agreements → New Agreement).
  2. In ISA Title, type KDFN-HPW-Whitehorse Generating Station-2026-2029.
  3. Verify no warning alert is displayed.
  4. Replace it with a Project/Purpose that itself contains a dash: CTFN-EMR-Highway Maintenance - Phase 2-2030-2035.
  5. Verify no warning appears (the shape check tolerates dashes inside the Project/Purpose segment).
  6. Replace it with a two-digit end year: CAFN-HPW-Highway Maintenance-2026-29.
  7. Verify the warning reappears (the pattern expects the YYYY-YYYY form per the acceptance criteria; this variant is flagged pending the year-format clarification raised on the ticket).

Test Case 4: Viewing an ISA shows the "ISA Title" label

  1. Click Sharing Agreements in the left sidebar nav.
  2. Click an existing agreement from the list to open its detail page.
  3. On the Basic Information card, verify the first field is labelled ISA Title (overline text above the title value).
  4. Verify the label does not read "Agreement Title" anywhere on the page.

@burkkyy burkkyy self-assigned this Sep 4, 2026
@burkkyy burkkyy added the enhancement New feature or request label Sep 4, 2026
@burkkyy
burkkyy marked this pull request as ready for review September 4, 2026 21:55
@burkkyy
burkkyy merged commit 6e23e4c into main Sep 4, 2026
3 checks passed
@burkkyy
burkkyy deleted the tk-65/isa-changes branch September 4, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant