Skip to content

TK-93: Show ISA optional fields when viewing an agreement - #65

Draft
burkkyy wants to merge 1 commit into
mainfrom
tk-93/isa-optional-field-editable-but-not-viewable
Draft

TK-93: Show ISA optional fields when viewing an agreement#65
burkkyy wants to merge 1 commit into
mainfrom
tk-93/isa-optional-field-editable-but-not-viewable

Conversation

@burkkyy

@burkkyy burkkyy commented Sep 4, 2026

Copy link
Copy Markdown
Member

Fixes https://yg-hpw.atlassian.net/browse/TK-93

Context

The optional Information Sharing Agreement sections added in TK-44 (level of detail, formats, credit lines, expiration/breach actions, and compelled-disclosure notes) were editable but never rendered on the agreement view page, so users could not see the complete agreement. The data was already serialized and returned by the API — only the view UI was missing.

Implementation

  • Add a read-only InformationSharingAgreementAdditionalDetailsCard.vue that mirrors the additional-details edit form (sections 2, 3, 7, 8, 9, 10), resolving each comma-joined column to its translated option labels and showing the free-text notes, with a "Not specified" fallback per section.
  • Render the card on InformationSharingAgreementPage.vue.
  • Add a component test covering label rendering, notes, the empty-section placeholder, and ignoring invalid option values.

Screenshots

TODO

Testing Instructions

  1. Run the test suite via dev test web.
  2. Boot the app via dev up.
  3. Log in to the app at http://localhost:8080.
  4. Click Information Sharing Agreements (ISAs) in the left sidebar nav.
  5. Click the New Agreement button, fill in the required fields, and click Create.
  6. Open the agreement, go to the Additional Details edit section, select options and enter notes across sections 2, 3, 7, 8, 9 and 10, and click Save.
  7. On the agreement view page, verify the new Additional Details card renders each selected option label and every notes value.
  8. Edit the agreement to clear the optional sections, save, and verify each section on the view card falls back to Not specified.

Known follow-up (not in this PR)

The generated Word template (confidentiality-acknowledgement-template.docx) still omits the optional sections. The backend serializer already maps every optional field to docxtemplater variables ({#detail_level.is_*}, {detail_notes}, {#formats.is_*}, {#credit_lines.is_*}, {credit_notes}, {#expiration_actions.is_*}, {expiration_notes}, {#breach_actions.is_*}, {breach_notes}, {disclosure_notes}); the binary template needs those placeholders added with the business-approved legal wording and layout.

@burkkyy burkkyy self-assigned this Sep 4, 2026
…ment.

The optional sections (detail level, formats, credit lines, expiration and breach actions, and the compelled-disclosure notes) were editable but never rendered on the agreement view page, so users could not see the complete agreement. Adds a read-only Additional Details card mirroring the edit form.

See https://yg-hpw.atlassian.net/browse/TK-93
@burkkyy
burkkyy force-pushed the tk-93/isa-optional-field-editable-but-not-viewable branch from 6f9fb2b to c48d97f Compare September 8, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant