TK-93: Show ISA optional fields when viewing an agreement - #65
Draft
burkkyy wants to merge 1 commit into
Draft
Conversation
…ment. The optional sections (detail level, formats, credit lines, expiration and breach actions, and the compelled-disclosure notes) were editable but never rendered on the agreement view page, so users could not see the complete agreement. Adds a read-only Additional Details card mirroring the edit form. See https://yg-hpw.atlassian.net/browse/TK-93
burkkyy
force-pushed
the
tk-93/isa-optional-field-editable-but-not-viewable
branch
from
September 8, 2026 22:54
6f9fb2b to
c48d97f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://yg-hpw.atlassian.net/browse/TK-93
Context
The optional Information Sharing Agreement sections added in TK-44 (level of detail, formats, credit lines, expiration/breach actions, and compelled-disclosure notes) were editable but never rendered on the agreement view page, so users could not see the complete agreement. The data was already serialized and returned by the API — only the view UI was missing.
Implementation
InformationSharingAgreementAdditionalDetailsCard.vuethat mirrors the additional-details edit form (sections 2, 3, 7, 8, 9, 10), resolving each comma-joined column to its translated option labels and showing the free-text notes, with a "Not specified" fallback per section.InformationSharingAgreementPage.vue.Screenshots
TODO
Testing Instructions
dev test web.dev up.http://localhost:8080.Known follow-up (not in this PR)
The generated Word template (
confidentiality-acknowledgement-template.docx) still omits the optional sections. The backend serializer already maps every optional field to docxtemplater variables ({#detail_level.is_*},{detail_notes},{#formats.is_*},{#credit_lines.is_*},{credit_notes},{#expiration_actions.is_*},{expiration_notes},{#breach_actions.is_*},{breach_notes},{disclosure_notes}); the binary template needs those placeholders added with the business-approved legal wording and layout.