ELCC-94: Add Per-Center Per-Month Building Expense Customization - #108
Merged
klondikemarlen merged 29 commits intoMar 16, 2026
Merged
klondikemarlen merged 29 commits into
klondikemarlen merged 29 commits into
Conversation
Why? Simplify code by removing redundant prefix.
Why? Simplify code by removing redundant prefix. Also testing out OpenAI Codex with GPT-5.4; good test!
…e and fiscal period. NOTE: back-end logic does not exist yet.
Why? Because it generally looks better (and we use this in other projects).
…building expense basis.
Why? Keeps the AGENTS file from growing to large and makes documentation at least potentially useful to developers, rather than just AI agents.
… building expense category. Why? To make it easier to add new categories to existing centres expense list.
…default. Why? Because it's not possible to remove building expenses categories once they are created this way.
Also fix expense display to show max entries rather than just a single page of data.
NOTE: we still need to restrict base on fiscal period end date.
klondikemarlen
force-pushed
the
elcc-94/add-per-center-per-month-building-expense-customization
branch
from
March 16, 2026 01:00
fc1e006 to
84032bc
Compare
klondikemarlen
force-pushed
the
elcc-94/add-per-center-per-month-building-expense-customization
branch
from
March 16, 2026 01:07
84032bc to
4c9a9df
Compare
Why? UI does not explain why editing is not allowed, so defering till the concept is better handled in the UI.
Why? UI does not explain why editing is not allowed, so defering till the concept is better handled in the UI.
klondikemarlen
marked this pull request as ready for review
March 16, 2026 16:04
klondikemarlen
deleted the
elcc-94/add-per-center-per-month-building-expense-customization
branch
March 16, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://yg-hpw.atlassian.net/browse/ELCC-94
Context
End users reported that building expenses are fairly informal and need to be customized on a per-month, per-center basis. The existing interface only supported bulk management at the category level, with no way to add, remove, or individually adjust expenses for specific centres and fiscal periods.
Implementation
categoryIdand update the related API, model, serializer, and migration layers.BaseModel.withScopetyping fix needed for scopedfindEachcalls.Screenshots
New Building Expense table with add/remove options.

http://localhost:8080/child-care-centres/1/2025-26/worksheets/march
Building expense form open.

http://localhost:8080/child-care-centres/1/2025-26/worksheets/march?showBuildingExpenseCreateForm=true
Category selector open with no category found and a link to create a category for admins.

http://localhost:8080/child-care-centres/1/2025-26/worksheets/march?showBuildingExpenseCreateForm=true
Expense category creation page with the apply-forward option.

http://localhost:8080/administration/building-expense-categories/new
Testing Instructions
dev test.dev up.http://localhost:8080.Test Case 1: User can add a building expense from a monthly worksheet
Search for a building expense category..Building expense created successfullyappears.Test Case 2: User can apply a building expense to later fiscal periods
Building expense created successfullyappears.Test Case 3: User can edit and delete a building expense
Building expense saved!appears.Building expense deleted!appears.Test Case 4: Past months remain editable
Building expense saved!appears.Building expense deleted!appears.Test Case 5: System admins can manage subsidy rate and create categories
Building expense saved!appears.Building expense category created successfully!appears.Test Case 6: Empty category search offers the admin create flow
Can't find what you're looking for?.