Issue 5: WRAP Integration - #6
Draft
klondikemarlen wants to merge 17 commits into
Draft
Conversation
I should really build a module system so I can do stuff like dev upgrade or dev add edit-pr
Model developed from current proof of concept in https://github.com/icefoganalytics/digital-vault/blob/17c091c8d2d5be3e31b093158cf45786a16e1ac2/api/src/controllers/integration-controller.ts
Very much a work in progress so update as needed. Take from https://github.com/icefoganalytics/wrap/blob/ea184b2d824cbfe312be8e23cd664877b4e6a017/AGENTS.md
Why? Easier to find and avoid duplicate exports.
Always use absolute import to avoid import loops.
klondikemarlen
force-pushed
the
issue-5/wrap-integration
branch
from
October 28, 2025 22:44
3610a28 to
0cbe5cd
Compare
I.e. so you can kill them quickly instead of having to wait for the 10s timeout. https://docs.docker.com/reference/compose-file/services/#init Code taken from icefoganalytics/wrap@e807713
See https://vuetifyjs.com/en/features/treeshaking/ NOTE: this fixes the double load bug on all routes on first load. Code taken from icefoganalytics/wrap@ea5fd72
Policy logic should be as simple as possible to avoid access loopholes.
Will replace with sources/:sourceId/submissions setup. TODO: delete all reference once they have been recreated in Submissions.CreateService.
Why? Easier to find and and avoid duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Relates to:
Context
Add ability to insert files from WRAP and received with a confirmation payload.
This should be a simpler process that creating all the dependent entities individually.
This is currently implemented on the DigitalVault side as https://github.com/icefoganalytics/digital-vault/blob/17c091c8d2d5be3e31b093158cf45786a16e1ac2/api/src/controllers/integration-controller.ts
On the WRAP side nothing exists, though the solution will be similar to the other integrations in https://github.com/icefoganalytics/wrap/tree/ea184b2d824cbfe312be8e23cd664877b4e6a017/api/src/integrations
Describe the solution you'd like
Endpoint:
Payload will include:
Response should include:
Additional context
Implementation
TODO
Screenshots
TODO
Testing Instructions
dev test(ordev test_api)dev up