Pdf merger - #2
Open
burkkyy wants to merge 7 commits into
Open
Conversation
burkkyy
marked this pull request as ready for review
March 29, 2025 01:08
burkkyy
commented
Mar 29, 2025
|
|
||
| // if (uploadResp.errorCode) { | ||
| // throw Error("File upload error") | ||
| // } |
Member
Author
There was a problem hiding this comment.
Where on the file store should the merged(and signed) pdf go?
burkkyy
commented
Mar 29, 2025
| // throw Error("File upload error") | ||
| // } | ||
|
|
||
| // update file record? |
Member
Author
There was a problem hiding this comment.
Does the file record need to be updated? Or does the filestore only care about the merged pdf?
burkkyy
commented
Mar 29, 2025
burkkyy
commented
Mar 29, 2025
burkkyy
commented
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Attachments in an archive item need to all be converted, merged and then signed into a single pdf ready for file store upload
Implementation
Testing Instructions
dev uphttp://localhost:8080/archive-items/newPENDING_FILESTORE_UPLOAD_ARCHIVE_ITEM_ID_