Fix GNOME 50 compatibility - #173
Open
SawanTeja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNOME 50 is Wayland only and no longer provides the X11 compositor backend, so global.compositor.disable_unredirect() and global.compositor.enable_unredirect() are no longer available and cause the extension to crash.
These calls were used to tell the X11 compositor to stop compositing while the search overlay was visible as a performance optimization. This is no longer necessary on Wayland, so the calls can be safely removed.
Changes
Removed three calls from extension.js:
global.compositor.disable_unredirect() from show()
global.compositor.enable_unredirect() from the hide() branch
global.compositor.enable_unredirect() from the other hide() branch
Tested On :
Fedora Linux 44 (Workstation Edition) x86_64
GNOME 50.4