Conversation
Defer show/hide actor-tree changes out of input handlers, unmap search widgets before detaching them, and guard against re-entrant hide() calls so Clutter 18 no longer aborts the session when the overlay is dismissed. Co-authored-by: Cursor <cursoragent@cursor.com>
…ones. Several close paths only set opacity to zero, leaving reactive chrome and the click catcher intercepting pointer events after the overlay looked hidden. Route those paths through full hide cleanup and release input capture immediately when closing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show()/hide()actor-tree work out of input and focus handlers so Clutter 18 on GNOME 50 no longer aborts during_release_ui()teardown.hide()to prevent nested teardown during focus changes._remove_events()to show-session listeners only, so permanentenable()listeners (overview, app-state, window-created) survive after close.overview-showing/overview-hiddentoshowing/hidden, improving GNOME 50 compatibility for overview tracking.This addresses the same root cause discussed in #82, #133, and #166, and complements open PR #164.
Test environment
Test plan
gnome-extensions disable/enable search-light@icedman.github.com)Made with Cursor