Fix blur background for wallpaper paths with special characters - #169
Open
Lija321 wants to merge 1 commit into
Open
Fix blur background for wallpaper paths with special characters#169Lija321 wants to merge 1 commit into
Lija321 wants to merge 1 commit into
Conversation
The blur-background feature passes the raw picture-uri gsettings value to the convert command. When the wallpaper filename contains characters that are percent-encoded in the URI (e.g. spaces as %20), imagemagick fails to open the file and the blurred background is never generated. Decode the URI with GLib.filename_from_uri() so convert receives the actual filesystem path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The blur-background feature passes the raw
picture-urigsettings value directly to theconvertcommand. When the wallpaper filename contains characters that get percent-encoded in the URI (e.g. a space encoded as%20), ImageMagick cannot open the file:The blurred background image is never generated, so enabling "Blur background" silently does nothing (gnome-shell then logs
Failed to load file:///tmp/searchlight-user-bg-blurred.jpg).Fix
Decode the URI with
GLib.filename_from_uri()in_updateBlurredBackground()soconvertreceives the actual filesystem path. Falls back to the raw value if the URI isn't afile://URI.Tested on GNOME Shell (Wayland) with a wallpaper named
2024-10-27-18-35-47-Acrylic 5.png— the blurred background now generates and displays correctly.