Fix: resolve Wayland dead zone by decoupling input region into a dedicated hitbox - #368
Open
MakdumIbrohim wants to merge 1 commit into
Open
Fix: resolve Wayland dead zone by decoupling input region into a dedicated hitbox#368MakdumIbrohim wants to merge 1 commit into
MakdumIbrohim wants to merge 1 commit into
Conversation
…cated hitbox actor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Wayland Phantom Window / Dead Zone (Unclickable Screen Area)
The Problem
Users on Wayland experience a "phantom window" or "dead zone" at the bottom of the screen where mouse clicks are not registered by applications behind the dock.
Root Cause:
this) is given a large footprint (fp). BecauseaffectsInputRegion: falsewas disabled/commented out duringaddChrome, Wayland treats this entire large transparent box as a compositor input region, swallowing mouse clicks.autohide_dashis disabled,this.strutsstretches full-width across the screen to act as a window manager strut (preventing maximized windows from overlapping). Since it also lackedaffectsInputRegion: false, it created a massive full-width horizontal dead zone.this.strutswas configured withtrackFullscreen: false, meaning the invisible struts remained on top of fullscreen windows (like movie players), blocking playback controls.The Solution (Architectural Fix)
This PR completely decouples the visual layout/animations, the window manager struts, and the Wayland input region (hitbox):
Introduced a Dedicated Hitbox (
this.hitbox)animator.jsto strictly match the exact bounds of the visual dock (dock._background).affectsInputRegion: true.Disabled Input Region on Large Containers
affectsInputRegion: falseto the main container (this). The large footprint (fp) now safely provides room for animations without blocking Wayland clicks.affectsInputRegion: falsetothis.struts. It continues to successfully push maximized windows away, but no longer intercepts mouse clicks across the full screen width.Fixed Fullscreen Interference
trackFullscreen: trueonthis.strutsandthis.hitboxso they properly sink below fullscreen applications, allowing users to click video player controls.Cleaner Debug Mode
debug_visuallogic so that the magenta debug outline.hionly highlights the actualthis.hitboxinstead of drawing confusing giant boxes for the struts and main containers.✅ Testing Done