Fix hidden dock blocking clicks on X11 - #367
Open
sagar431 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the stationary outer dock container from contributing its full allocation to the X11 input region on GNOME Shell 4x.
When autohide slides the inner dash off-screen, the outer
dashtodockContainerremains allocated across the bottom of the monitor. SinceaffectsInputRegion: falsewas removed during the GNOME 50 compatibility changes, that invisible allocation can continue intercepting clicks intended for maximized applications.Change
Restore
affectsInputRegion: falsefor the outer dock chrome actor, gated to GNOME Shell 4x using the sameConfig.PACKAGE_VERSION[0] == '4'pattern already used for the struts actor. GNOME 50 behavior is unchanged.The separate reactive
DockDwellactor remains intact, so edge reveal, pressure sensing, and the existing slide animation are unaffected.Verification
node --input-type=module --check < dock.jspasses.git diff --checkpasses.This is a deliberately minimal version of the input-region fix discussed in #366.