Add apps-icon-name pref: themed icon override for the apps button - #354
Open
svan71 wants to merge 1 commit into
Open
Add apps-icon-name pref: themed icon override for the apps button#354svan71 wants to merge 1 commit into
svan71 wants to merge 1 commit into
Conversation
Like dash-to-dock's show-apps icon swap: a string pref (empty = stock grid icon) applied to the real ShowAppsIcon St.Icon in _inspectIcon, with fallback_icon_name so missing theme names degrade to the stock icon. The animated renderer inherits it via icon_name cloning. Restored on icon cleanup. Also completes the half-implemented 'string' pref plumbing in PrefKeys: setValue never persisted strings to GSettings, connectBuilder had no string case (entries never saved), and connectSettings called set_value on widgets that only have set_text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
apps-icon-namestring preference (Tweaks page) to override the "Show Apps" button with any themed icon name — same idea as dash-to-dock's show-apps icon swap. Empty string (default) keeps the stock grid icon. The override is applied to the realShowAppsIconSt.Icon in_inspectIconwithfallback_icon_nameset to the stock icon, so a missing/misspelled theme name degrades gracefully instead of showing a broken icon. The animated renderer picks it up automatically viaicon_namecloning, and the stock icon is restored on cleanup/disable.This also completes the half-implemented
stringpref plumbing inPrefKeys, which the new pref needs but which affects any future string pref:setValuenever persisted string-type prefs to GSettingsconnectBuilderhad nostringcase, so text entries never savedconnectSettingscalledset_valueon entry widgets that only haveset_textTested on GNOME 50 (Arch): pref persists across sessions, icon swaps live, bad names fall back to the stock grid icon.