Skip to content

Add more ability of autohide if only active windows. #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joevnpro wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add more ability of autohide if only active windows. #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0edfb2a
Prevent dock display in fullscreen from overview
joevnpro Feb 25, 2026
60c09c0
The option to change icon From Smaller to bigger
joevnpro Feb 25, 2026
233637a
Able to hide the dock if only it is the active windows
joevnpro Feb 25, 2026
2734c1e
Refactor autohide mode handling and overlap logic
joevnpro Feb 26, 2026
80828ea
Improve comments in autohide.js
joevnpro Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 132 additions & 32 deletions autohide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const handledWindowTypes = [
Meta.WindowType.DIALOG,
Meta.WindowType.MODAL_DIALOG,
// Meta.WindowType.TOOLBAR,
// Meta.WindowType.MENU,
Meta.WindowType.MENU,
Meta.WindowType.DROPDOWN_MENU, // to hide the dock in case the right mouse menu and Dropdown menu overlap the dock.
Meta.WindowType.UTILITY,
// Meta.WindowType.SPLASHSCREEN
];
Expand Down Expand Up @@ -142,8 +143,9 @@ export let AutoHide = class {
this._debounceCheckHide();
}

// The dock will show back in Overview (if open Overview from a state of an opened app with fullcreen status
show() {
if (!this.dock._monitor || this.dock._monitor.inFullscreen) {
if (!this.dock._monitor || (this.dock._monitor.inFullscreen && !this.extension._inOverview)) {
return;
}
this._dwell = 0;
Expand Down Expand Up @@ -191,6 +193,11 @@ export let AutoHide = class {
}

_checkOverlap() {
// Declare mode of autohide
let mode1_allWindows = 1;
let mode2_onlyActiveWindows = 2;
let mode_selected = mode2_onlyActiveWindows;

// console.log("checking overlap...");
if (this.extension._inOverview) {
return false;
Expand Down Expand Up @@ -238,44 +245,137 @@ export let AutoHide = class {

let monitor = this.dock._monitor;
let actors = global.get_window_actors();
let windows = actors.map((a) => {

// Add popumMenu to hide the dock if the right mouse menu overlap the doc (becasuse this dock is design to be always over everything)
let popupMenus = actors
.map(a => a.get_meta_window())
.filter(w =>
w &&
(w.get_window_type() === Meta.WindowType.DROPDOWN_MENU ||
w.get_window_type() === Meta.WindowType.POPUP_MENU ||
w.get_window_type() === Meta.WindowType.MENU)
);

// Hide the dock if any windows overlaps the dock.
const _checkOverlap1 = () => {
let windows = actors.map((a) => {
let w = a.get_meta_window();
w._parent = a;
return w;
});
windows = windows.filter((w) => w.can_close());
windows = windows.filter((w) => w.get_monitor() == monitor.index);
// windows = windows.filter((w) => !w.is_override_redirect());
let workspace = global.workspace_manager.get_active_workspace_index();
windows = windows.filter(
(w) =>
workspace == w.get_workspace().index() && w.showing_on_its_workspace()
);
windows = windows.filter((w) => w.get_window_type() in handledWindowTypes);

let isOverlapped = false;
let dockRect = this.dock.struts.get_transformed_position();
dockRect.push(this.dock.struts.width);
dockRect.push(this.dock.struts.height);
});

windows = windows.filter((w) => w.can_close());
windows = windows.filter((w) => w.get_monitor() == monitor.index);
// windows = windows.filter((w) => !w.is_override_redirect());
let workspace = global.workspace_manager.get_active_workspace_index();
windows = windows.filter(
(w) =>
workspace == w.get_workspace().index() && w.showing_on_its_workspace()
);
windows = windows.filter((w) => w.get_window_type() in handledWindowTypes);


// Add popup and right mouse menu to check
popupMenus.forEach(m => {
if (m && m.get_monitor() === monitor.index) {
windows.push(m);
}
});


let isOverlapped = false;
let dockRect = this.dock.struts.get_transformed_position();
dockRect.push(this.dock.struts.width);
dockRect.push(this.dock.struts.height);

windows.forEach((w) => {
this._track(w);
if (isOverlapped) return;

let frame = w.get_frame_rect();
let win = [frame.x, frame.y, frame.width, frame.height];

if (isOverlapRect(dockRect, win)) {
isOverlapped = true;
}
});

windows.forEach((w) => {
this._track(w);
if (isOverlapped) return;
this.windows = windows;

let frame = w.get_frame_rect();
let win = [frame.x, frame.y, frame.width, frame.height];
// console.log(isOverlapped);
return isOverlapped;
}

if (isOverlapRect(dockRect, win)) {
isOverlapped = true;
// Hide the dock if only there is an overlap of active windows on the dock,
let focused = global.display.get_focus_window();
let checkWindows = [];

const _checkOverlap2 = () => {
if (focused && focused.get_monitor() === monitor.index) {
let winType = focused.get_window_type();
let isValidAppWindows = false;
for (let i = 0; i < actors.length; i++) {
let win = actors[i].get_meta_window();

// So sánh đối tượng cửa sổ
if (win === focused) {
isValidAppWindows = true;
break;
}
}
if (isValidAppWindows && winType !== Meta.WindowType.DESKTOP && focused.can_close()) {
checkWindows.push(focused);
}
}

popupMenus.forEach(w => {
if (w.get_monitor() === monitor.index) {
checkWindows.push(w);
}
});

this.windows = checkWindows;
if (checkWindows.length === 0) {
return false;
}
});

this.windows = windows;

// console.log(isOverlapped);
return isOverlapped;

let dockRect = this.dock.struts.get_transformed_position();
dockRect.push(this.dock.struts.width);
dockRect.push(this.dock.struts.height);

let isOverlapped = false;

checkWindows.forEach(w => {
this._track(w);
if (isOverlapped) return;

let frame = w.get_frame_rect();
let win = [frame.x, frame.y, frame.width, frame.height];

if (isOverlapRect(dockRect, win)) {
isOverlapped = true;
}
});

return isOverlapped;
}

let overlap = false;

if(mode_selected === mode1_allWindows) {
overlap = _checkOverlap1();
return overlap;
}

if(mode_selected === mode2_onlyActiveWindows) {
overlap = _checkOverlap2();
return overlap;
}

return overlap;
}



_debounceCheckHide() {
if (this.extension._loTimer) {
if (!this._debounceCheckSeq) {
Expand Down
53 changes: 28 additions & 25 deletions dock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,36 +463,39 @@ export let Dock = GObject.registerClass(
);
}

//Icon size from smaller to bigger.
_preferredIconSize() {
let preferredIconSizes = this._preferredIconSizes;
let iconSize = 64;
if (!preferredIconSizes) {
preferredIconSizes = [32];
for (let i = 16; i <= 128; i += 4) {
preferredIconSizes.push(i);
}
this._preferredIconSizes = preferredIconSizes;
}
let defaultSize=32; //if there is an error in caculaton, use this value.
this._iconSize=defaultSize;

//To ensure the extension object and _config object exist (prevent crash system in case the Dock.js is load but the _config.jon hasnot been load because
// _loadConfig() is an async function
const extExtention = this.extension || {};
const extConfig = extExtention._config || {};//This is this.extension._config

//! why the need for upscaling
let upscale = 1 + (2 - this._scaleFactor) || 1;
if (upscale < 1) {
upscale = 1; // does scaleFactor go beyond 2x?
// 1. Prioritize manual input from config
if (extConfig.icon_size) { //this.extension._config.icon_size
return this._iconSize = extConfig.icon_size;
}
// console.log(`scaleFactor:${this._scaleFactor} upscale:${upscale}`);
iconSize =
upscale *
(preferredIconSizes[
Math.floor(this.extension.icon_size * preferredIconSizes.length)
] || 64);
iconSize *= this.extension.scale;

if (this.extension._config.icon_size) {
iconSize = this.extension._config.icon_size;
}
// 2. Get value from UI slider (assuming range 0.0 to 1.0)
let sliderVal = extExtention.icon_size;

// 3. Define the size range you want (e.g., from 16px to 128px)
let min = 8;
let max = 128;

// Calculate base size based on slider position (Linear - prevents sudden jumps)
let baseSize = min + (sliderVal * (max - min));

// 4. Multiply by screen scale factor (upscale) and extension-specific ratio
let scaleFactor = this._scaleFactor || 1;
let upscale = Math.max(1, 1 + (2 - scaleFactor))||1;
let extExtentionScale = extExtention.scale || 1;

this._iconSize = baseSize * upscale * extExtentionScale;

this._iconSize = iconSize;
return iconSize;
return this._iconSize||defaultSize;
}

// Structure for dash icon container widgets - g42,g43,g44,g45,g46
Expand Down