Skip to content

fix(auth): recognize registered accounts and offer safe sign-in - #3732

Draft
ccycv wants to merge 1 commit into
ice-blockchain:masterfrom
ccycv:fix/existing-account-login-recovery-20261029
Draft

ccycv wants to merge 1 commit into
ice-blockchain:masterfrom
ccycv:fix/existing-account-login-recovery-20261029

Conversation

@ccycv

@ccycv ccycv commented Oct 29, 2026

Copy link
Copy Markdown

Summary

  • Recognize HTTP 409 account conflicts using both legacy User already exists and current User has already registered provider messages, including the legacy JSON-string response.
  • Offer an explicit existing-account sign-in action on both signup forms. Return to the standard sign-in screen, not the password-registration fallback.
  • Preserve the disabled automatic-login feature flag and all existing passkey/password/2FA checks. No account reset, credential replacement, storage clearing, wallet change, or backend deployment.

Validation

Using the repository-pinned Flutter 3.35.3 / Dart 3.9.2:

  • cd packages/ion_identity_client && flutter test --no-pub test/core/types/user_already_exists_exception_test.dart test/auth/services/register/existing_account_registration_test.dart --reporter expanded: 30 passed. The service tests exercise NetworkClient through registration-init and fail on any signer/token-storage mutation.
  • flutter test --no-pub --no-test-assets test/app/features/auth/flows/return_to_existing_account_login_test.dart --reporter expanded: 1 passed. The test disables material splash shaders because the private app asset bundle is unavailable.
  • Focused analysis of exception parser, both package tests, navigation helper and navigation test: no issues.
  • git diff --check: passed.

Review And Release Gate

Implementer reviewed commit 7466c96c62568b7b982a65617b682ad0381abcb1: no blocking logic/security findings in the scoped diff. This does not bypass authentication or recover an inaccessible credential.
Draft: complete signup-screen analysis/build and real-device passkey/password/2FA QA remain required. The public checkout lacks generated Riverpod/assets sources and private assets/ion_identity/coins.json; full signup-screen analysis and the default asset-bundled test invocation could not pass in this environment. No fake environment/assets were created. No new GitHub workflows or hosted requirements were added.
A registered provider account with a lost credential still requires valid existing credentials or a separately authorized provider recovery procedure; this UI compatibility patch does not reset it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant