Update dependency uvicorn to v0.51.0#943
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate the pinned uvicorn dependency from version 0.50.2 to 0.51.0 in the backend requirements file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given uvicorn 0.51.0 adds overlapping worker restarts on SIGHUP, double-check any deployment or process manager scripts that send SIGHUP to ensure the new behavior matches your expectations for reloads.
- Since colorama was removed from the standard extras in uvicorn 0.51.0, confirm that any logging/color usage in your app or tooling doesn’t implicitly depend on colorama being installed via uvicorn.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given uvicorn 0.51.0 adds overlapping worker restarts on SIGHUP, double-check any deployment or process manager scripts that send SIGHUP to ensure the new behavior matches your expectations for reloads.
- Since colorama was removed from the standard extras in uvicorn 0.51.0, confirm that any logging/color usage in your app or tooling doesn’t implicitly depend on colorama being installed via uvicorn.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
===========================================
+ Coverage 62.06% 86.06% +23.99%
===========================================
Files 91 63 -28
Lines 3978 3574 -404
Branches 0 662 +662
===========================================
+ Hits 2469 3076 +607
+ Misses 1509 278 -1231
- Partials 0 220 +220 see 154 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==0.50.2→==0.51.0Release Notes
Kludex/uvicorn (uvicorn)
v0.51.0: Version 0.51.0Compare Source
What's Changed
Full Changelog: Kludex/uvicorn@0.50.2...0.51.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.