Update dependency bcrypt to v5#913
Draft
red-hat-konflux[bot] wants to merge 1 commit into
Draft
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate Python backend bcrypt dependency constraints to allow bcrypt 5.x and bump pinned version to 5.0.0, aligning pyproject and pinned requirements with the Renovate recommendation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider aligning the version constraint in
pyproject.tomlwith the exact version pinned inrequirements-pinned.txtto avoid potential resolver conflicts between the loose and pinned bcrypt versions. - Since
flask_bcryptdepends onbcrypt, it may be worth quickly checking its supported bcrypt versions and documenting any known incompatibilities if bcrypt 5.x introduces behavioral changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider aligning the version constraint in `pyproject.toml` with the exact version pinned in `requirements-pinned.txt` to avoid potential resolver conflicts between the loose and pinned bcrypt versions.
- Since `flask_bcrypt` depends on `bcrypt`, it may be worth quickly checking its supported bcrypt versions and documenting any known incompatibilities if bcrypt 5.x introduces behavioral changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 63 63
Lines 3574 3574
Branches 662 662
=======================================
Hits 3076 3076
Misses 278 278
Partials 220 220 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
<5→<6==4.3.0→==5.0.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.