Skip to content

Update dependency bcrypt to v5#913

Draft
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/bcrypt-5.x
Draft

Update dependency bcrypt to v5#913
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/bcrypt-5.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
bcrypt <5<6 age confidence
bcrypt ==4.3.0==5.0.0 age confidence

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@sourcery-ai

sourcery-ai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update Python backend bcrypt dependency constraints to allow bcrypt 5.x and bump pinned version to 5.0.0, aligning pyproject and pinned requirements with the Renovate recommendation.

File-Level Changes

Change Details Files
Relax bcrypt upper-bound in application dependencies and bump pinned bcrypt version to 5.0.0.
  • Change generic bcrypt dependency constraint from <5 to <6 in backend Python project configuration.
  • Update pinned bcrypt version from 4.3.0 to 5.0.0 in backend requirements to match the new allowed range.
backend/pyproject.toml
backend/requirements-pinned.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider aligning the version constraint in pyproject.toml with the exact version pinned in requirements-pinned.txt to avoid potential resolver conflicts between the loose and pinned bcrypt versions.
  • Since flask_bcrypt depends on bcrypt, it may be worth quickly checking its supported bcrypt versions and documenting any known incompatibilities if bcrypt 5.x introduces behavioral changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider aligning the version constraint in `pyproject.toml` with the exact version pinned in `requirements-pinned.txt` to avoid potential resolver conflicts between the loose and pinned bcrypt versions.
- Since `flask_bcrypt` depends on `bcrypt`, it may be worth quickly checking its supported bcrypt versions and documenting any known incompatibilities if bcrypt 5.x introduces behavioral changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.06%. Comparing base (609af01) to head (507bd74).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files          63       63           
  Lines        3574     3574           
  Branches      662      662           
=======================================
  Hits         3076     3076           
  Misses        278      278           
  Partials      220      220           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609af01...507bd74. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mshriver mshriver marked this pull request as draft July 8, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants