photogrammetry: expose units kwarg, refuse non-mm downstream#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photogrammetry Scans by Scaniverse are by default in meters. While running the face-anonymization pipeline, the landmark picker silently failed because it is currently restricted to 'mm'.
This PR exposes units (and crs) as kwargs to the user, allowing them to provide the correct metadata when loading photogrammetry scans. Converting units still needs to be done by the users themselves, but I added proper NotImplementedErrors to where cedalions photogrammetry pipeline silently assumes 'mm':
# FIXME unit handlingcomments in plot() now made redundant by the guard.