Conversation
The fork no longer declares `replace` for `jms/translation-bundle`, so the package has to be required under its own name.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ibexa/jms-translation-bundle3.0.0 is the Symfony 8 compatible major. Symfony 8.0 removed the XML DI configuration format the bundle relied on, so the 2.x line cannot boot on Symfony 8 at all — this is a prerequisite for the wider Symfony 8 upgrade (IBX-12046).3.0.0 drops the
replace: {"jms/translation-bundle": "^2.6"}entry. This repo requiredjms/translation-bundle ^2.4and was being satisfied by the fork purely through thatreplace. With it gone, keeping the old name would silently resolve to the upstreamjms/translation-bundlepackage instead of the Ibexa fork — two copies of the same classes in the dependency graph. So the requirement is switched to the fork's own name.The entry is moved into its correct alphabetical position among the other
ibexa/*packages, since this repo hasconfig.sort-packagesenabled.Merge order
Blocked until
ibexa/jms-translation-bundle3.0.0 is tagged. Until then^3.0will not resolve and CI here will fail on dependency resolution — that is expected, not a defect in this PR.Bundle PR: ibexa/jms-translation-bundle#10
Risk
No code changes are needed. The bundle's container shape is unchanged across 2.x → 3.0 — service ids, aliases, tags and visibility flags were verified byte-for-byte identical — and the
parent:/tag/decoratesextension points used by Ibexa packages resolve identically before and after.