IBX-12043: Upgraded to Doctrine DBAL 4 - #138
Merged
Merged
Conversation
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
August 20, 2026 12:54
6efe053 to
05a5f35
Compare
barw4
approved these changes
Aug 28, 2026
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
August 31, 2026 09:07
05a5f35 to
b09d2e3
Compare
bnowak
approved these changes
Sep 2, 2026
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 09:00
b09d2e3 to
4093baa
Compare
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 09:34
4093baa to
4234d30
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
ibexa/corepinsdoctrine/dbal, so DBAL 4 arrives here whether or not this package was ported. One call site is affected:invitationExistsForEmail()builtSELECT 1by passing the integer1toselect(), which DBAL 4 types asstring ...$expressions. Every invitation-existence check would be aTypeError.This was found in
phpstan-baseline.neonrather than in the source, and the entry states the defect outright:Under DBAL 3 that was a type-hint violation that happened to work; under DBAL 4 it is a hard failure. The entry is removed rather than regenerated.
Nothing else here needs porting.
lastInsertId()is used once, onibexa_user_invitations, which isSERIAL/auto-increment, so DBAL 4'sNoIdentityValuedoes not apply.For QA:
Inviting a user, and inviting an address that has already been invited — the second is the path through the changed query.
Documentation:
N/A