Skip to content

IBX-12654: Fixed dynamic calls to static methods - #34

Merged
wiewiurdp merged 1 commit into
6.0from
IBX-12654-fixed-dynamic-calls-to-static-methods
Sep 23, 2026
Merged

wiewiurdp merged 1 commit into
6.0from
IBX-12654-fixed-dynamic-calls-to-static-methods

Conversation

@bnowak

@bnowak bnowak commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-12654

Related PRs:

Description:

Replaces dynamic calls to static methods ($this->assertX(), static test helpers, ...) with self::/ClassName:: calls: 2 calls in 1 file. The staticMethod.dynamicCall strict rule itself is enabled in the linked ibexa/phpstan PR; this PR keeps CI green once that is released.

Both calls are $this->assertSame() inside a self::callback() closure in tests/lib/Component/ControllerComponentTest.php. php-cs-fixer's php_unit_test_case_static_method_calls rule deliberately skips closures, so they were changed by hand to self::assertSame(); composer fix-cs then made the closure static because it no longer uses $this.

For QA:

No functional change. CI (PHPStan, code style, unit tests) is the verification.

Documentation:

No client-facing impact.

@wiewiurdp
wiewiurdp merged commit d0351c9 into 6.0 Sep 23, 2026
12 checks passed
@wiewiurdp
wiewiurdp deleted the IBX-12654-fixed-dynamic-calls-to-static-methods branch September 23, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants