Added ability to test for specific HTTP response status code - #16
Merged
Conversation
…StatusCode` property
alongosz
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
August 20, 2025 16:05
adamwojs
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
If a REST endpoint returns non-200 HTTP status code, e.g.: 201 (Created) or 204 (No Content) it's good to test that the response returns that actual code rather than checking if the response was just successful (HTTP statuses >=200 and <300).
This PR adds that ability by adding yet another property to the
EndpointRequestDefinitionSPI. If not given, the current behavior of checking for a success is preserved. While it mostly applies to other success statuses, it can be applied to checking a contents of a 401, 403, 404, etc., responses.See either the test coverage or the related PR for the usage.
For QA:
No QA required
Documentation: