IBX-12594: Bumped ibexa/jms-translation-bundle to ^3.0 - #50
Merged
Merged
Conversation
Picks up the Symfony 8 compatible major.
ViniTou
force-pushed
the
ibx-12594-jms-translation-bundle-3
branch
from
September 21, 2026 12:35
9cc6692 to
3220fc9
Compare
ViniTou
force-pushed
the
ibx-12594-jms-translation-bundle-3
branch
from
September 21, 2026 12:41
ae0140d to
3220fc9
Compare
bnowak
approved these changes
Sep 21, 2026
barw4
approved these changes
Sep 21, 2026
Collaborator
|
Add dependencies.json to prove that it will work with the right set of dependencies :) |
alongosz
approved these changes
Sep 21, 2026
konradoboza
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ibexa/jms-translation-bundle3.0.0 is the Symfony 8 compatible major. Symfony 8.0 removed the XML DI configuration format that the bundle relied on, so the 2.x line cannot boot on Symfony 8 at all — this bump is a prerequisite for the wider Symfony 8 upgrade (IBX-12046).3.0.0 also drops the
replace: {"jms/translation-bundle": "..."}entry, which is why the sibling PRs inadmin-ui,userandtaxonomyswitch to requiring the fork by name. This repo already required it by name, so only the constraint changes here.Merge order
This PR merges first in the IBX-12594 set.
ibexa/core6.0.x-dev still requiresibexa/jms-translation-bundle ^2.6.1, and this repo hasibexa/coreinrequire-dev— so each side needs the other at^3.0before its own CI can resolve. CI here is red until this merges; that is the cycle, not a defect. It was proven green withibexa/coretemporarily pinned to its IBX-12594 branch (pin since dropped):✅ https://github.com/ibexa/test-core/actions/runs/35600826505 — resolved
ibexa/core dev-ibx-12594-jms-translation-bundle-3+ibexa/jms-translation-bundle 3.0.0, all jobs green.Once this merges,
ibexa/core#829resolves on its own and the rest follow:Risk
The bundle's container shape is unchanged across 2.x → 3.0: service ids, aliases, tags and visibility flags were verified byte-for-byte identical, and the
parent:/tag/decoratesextension points this repo relies on resolve identically. No service definitions in this repo need to change.