IBX-12043: Upgraded to Doctrine DBAL 4 - #90
Merged
Merged
Conversation
barw4
approved these changes
Aug 28, 2026
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
August 31, 2026 10:31
0359c7d to
b125ac3
Compare
bnowak
approved these changes
Sep 2, 2026
DatabasePlatformResolver moved to ibexa/doctrine-schema, so the System Info page died with "Class Ibexa\Core\Persistence\Doctrine\DatabasePlatformResolver not found" while rendering. The resolver also returns null for an unrecognised platform rather than throwing, so the catch it was wrapped in could never fire. doctrine-schema becomes a direct requirement, since production code now imports from it rather than relying on it arriving through ibexa/core. Join conditions and ExpressionBuilder are string-only in DBAL 4. One join condition was suppressed in the PHPStan baseline rather than fixed, which hid a TypeError that only shows up when the metric runs; that entry is gone.
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 09:34
b125ac3 to
7941a71
Compare
ViniTou
changed the title
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 10:57
7941a71 to
99ea023
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
DatabasePlatformResolvermoved toibexa/doctrine-schemaas part of this upgrade, so the System Info page died while rendering withClass "Ibexa\Core\Persistence\Doctrine\DatabasePlatformResolver" not found. The resolver also returnsnullfor a platform it does not recognise instead of throwing, so thecatch (InvalidArgumentException)around it could never fire and->valuewould have fataled on an unknown platform.ibexa/doctrine-schemabecomes a direct requirement rather than a dev one, since production code imports from it instead of relying on it arriving throughibexa/core.The metrics collectors needed the DBAL 4 pass too:
ExpressionBuilderis string-only and was being handed status constants as integers, and one join condition passed aCompositeExpression. That last one was suppressed inphpstan-baseline.neonrather than fixed — a baseline silences the analyser, not PHP, so it was aTypeErrorwaiting for the drafts metric to run. The entry is removed.For QA:
Admin → System Information, specifically the database section, plus the repository metrics shown there.
Documentation:
N/A