IBX-12654: Added ibexa/phpstan and fixed dynamic calls to static methods

composer.json

@@ -49,6 +49,7 @@
     "require-dev": {
         "ibexa/code-style": "~2.0.0",
         "ibexa/doctrine-schema": "~6.0.x-dev",
+        "ibexa/phpstan": "~6.0.x-dev",
         "ibexa/rector": "~6.0.x-dev",
         "ibexa/test-core": "~6.0.x-dev",
         "justinrainbow/json-schema": "^5.2",

phpstan-baseline.neon

@@ -1110,12 +1110,6 @@ parameters:
 			count: 1
 			path: tests/bundle/Functional/RootTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Bundle\\Rest\\Functional\\RootTest\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 54
-			path: tests/bundle/Functional/RootTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Bundle\\Rest\\Functional\\RootTest\:\:testResultContainsContentByRemoteIdTag\(\) has parameter \$result with no type specified\.$#'
 			identifier: missingType.parameter
@@ -1950,90 +1944,18 @@ parameters:
 			count: 1
 			path: tests/lib/Server/Output/ValueObjectVisitor/CachedValueTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 3
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentObjectStatesTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentTypeGroupListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 12
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentTypeGroupTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentTypeInfoListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ContentTypeListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/LocationListTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Rest\\Server\\Output\\ValueObjectVisitor\\LocationTest\:\:getDataForTestVisitLocationAttributesResolvesMainLocation\(\) return type has no value type specified in iterable type iterable\.$#'
 			identifier: missingType.iterableValue
 			count: 1
 			path: tests/lib/Server/Output/ValueObjectVisitor/LocationTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ObjectStateGroupListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/ObjectStateListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/PolicyListTest.php
-
 		-
 			message: '#^Parameter \#2 \$path of class Ibexa\\Rest\\Server\\Values\\PolicyList constructor expects string, int given\.$#'
 			identifier: argument.type
 			count: 1
 			path: tests/lib/Server/Output/ValueObjectVisitor/PolicyListTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 7
-			path: tests/lib/Server/Output/ValueObjectVisitor/PolicyTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/RelationListTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Rest\\Server\\Output\\ValueObjectVisitor\\RestFieldDefinitionTest\:\:getXpathAssertions\(\) return type has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -2064,78 +1986,12 @@ parameters:
 			count: 1
 			path: tests/lib/Server/Output/ValueObjectVisitor/RestFieldDefinitionTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 7
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestLocationRootNodeTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 22
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestLocationTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 11
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestObjectStateTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 6
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestRelationTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 4
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestTrashItemTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 4
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestUserGroupRoleAssignmentTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 4
-			path: tests/lib/Server/Output/ValueObjectVisitor/RestUserRoleAssignmentTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 3
-			path: tests/lib/Server/Output/ValueObjectVisitor/RoleAssignmentListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/RoleListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 5
-			path: tests/lib/Server/Output/ValueObjectVisitor/RoleTest.php
-
 		-
 			message: '#^Unreachable statement \- code above always terminates\.$#'
 			identifier: deadCode.unreachable
 			count: 3
 			path: tests/lib/Server/Output/ValueObjectVisitor/RoleTest.php
 
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 6
-			path: tests/lib/Server/Output/ValueObjectVisitor/RootTest.php
-
 		-
 			message: '#^Method Ibexa\\Tests\\Rest\\Server\\Output\\ValueObjectVisitor\\RootTest\:\:testResultContainsRouterWithAttributes\(\) has parameter \$result with no type specified\.$#'
 			identifier: missingType.parameter
@@ -2153,81 +2009,3 @@ parameters:
 			identifier: missingType.parameter
 			count: 1
 			path: tests/lib/Server/Output/ValueObjectVisitor/RootTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/SectionListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 5
-			path: tests/lib/Server/Output/ValueObjectVisitor/SectionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/TrashTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/URLAliasListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 9
-			path: tests/lib/Server/Output/ValueObjectVisitor/URLAliasTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/URLWildcardListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 5
-			path: tests/lib/Server/Output/ValueObjectVisitor/URLWildcardTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/UserGroupListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/UserListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 7
-			path: tests/lib/Server/Output/ValueObjectVisitor/UserSessionTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 10
-			path: tests/lib/Server/Output/ValueObjectVisitor/VersionInfoTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 2
-			path: tests/lib/Server/Output/ValueObjectVisitor/VersionListTest.php
-
-		-
-			message: '#^Method Ibexa\\Tests\\Rest\\Output\\ValueObjectVisitorBaseTestCase\:\:assertXMLTag\(\) invoked with 4 parameters, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 3
-			path: tests/lib/Server/Output/ValueObjectVisitor/VersionTest.php

phpstan.neon

@@ -2,6 +2,7 @@ includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-symfony/extension.neon
     - vendor/phpstan/phpstan-webmozart-assert/extension.neon
+    - vendor/ibexa/phpstan/extension.neon
     - phpstan-baseline.neon
 
 parameters:

src/lib/Server/Input/Parser/Criterion/ContentTypeIdentifier.php

@@ -42,7 +42,7 @@ public function parse(array $data, ParsingDispatcher $parsingDispatcher): Conten
 
         return new ContentTypeIdCriterion(
             array_map(
-                function ($contentTypeIdentifier) {
+                function ($contentTypeIdentifier): int {
                     return $this->contentTypeService->loadContentTypeByIdentifier($contentTypeIdentifier)->id;
                 },
                 $data['ContentTypeIdentifierCriterion']

tests/bundle/EventListener/CsrfListenerTest.php

@@ -37,7 +37,7 @@ public static function provideExpectedSubscribedEventTypes(): array
     public function testIsNotRestRequest(): void
     {
         $listener = $this->getEventListener();
-        $request = $this->createStub(Request::class);
+        $request = self::createStub(Request::class);
         $request->attributes = new ParameterBag();
 
         $listener->onKernelRequest(
@@ -47,7 +47,7 @@ public function testIsNotRestRequest(): void
 
     public function testCsrfDisabled(): void
     {
-        $request = $this->createStub(Request::class);
+        $request = self::createStub(Request::class);
         $request->attributes = new ParameterBag([
             'is_rest_request' => true,
         ]);
@@ -130,7 +130,7 @@ public function testSessionRequests(): void
 
     public function testSkipCsrfProtection(): void
     {
-        $request = $this->createStub(Request::class);
+        $request = self::createStub(Request::class);
         $request->attributes = $this->getRequestAttributesMock();
         $request->headers = $this->getRequestHeadersMock();
 

tests/bundle/EventListener/EventListenerTestCase.php

@@ -34,7 +34,7 @@ public function testGetSubscribedEvents(array $expectedEventTypes): void
     {
         $eventListener = $this->getEventListener();
 
-        $supportedEvents = $eventListener->getSubscribedEvents();
+        $supportedEvents = $eventListener::getSubscribedEvents();
         $supportedEventTypes = array_keys($supportedEvents);
         sort($supportedEventTypes);
         sort($expectedEventTypes);

tests/bundle/EventListener/RequestListenerTest.php

@@ -90,14 +90,14 @@ public function testOnKernelRequest(string $uri, bool $isExpectedRestRequest): v
     protected function getEventListener(?bool $csrfEnabled = null): RequestListener
     {
         return new RequestListener(
-            new UriParser($this->createStub(UrlMatcherInterface::class))
+            new UriParser(self::createStub(UrlMatcherInterface::class))
         );
     }
 
     protected function performFakeRequest(string $uri, int $type = HttpKernelInterface::MAIN_REQUEST): Request
     {
         $event = new RequestEvent(
-            $this->createStub(HttpKernelInterface::class),
+            self::createStub(HttpKernelInterface::class),
             Request::create($uri),
             $type
         );

tests/bundle/EventListener/SupportedMediaTypesSubscriberTest.php

@@ -25,7 +25,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->kernel = $this->createStub(HttpKernelInterface::class);
+        $this->kernel = self::createStub(HttpKernelInterface::class);
     }
 
     public function testDoesNothingWhenSupportedMediaTypesParameterIsNotSet(): void