IBX-12180: [ibexa/page-builder] Added REST routing import to experience and commerce recipes - #260
Merged
Conversation
…ipes Co-Authored-By: Bartłomiej Nowak <5451843+bnowak@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
Redo of ibexa/recipes#117 in the correct repo.
ibexa/recipesserves recipes for released versions only. Flex doesn't support tagging recipe versions, so development changes land here, inrecipes-dev, and get fast-forwarded ontoibexa/recipesduring the release. #117 went straight intoibexa/recipesand reached existing installations through the documented upgrade step (composer recipes:install ibexa/experience --force), crashing the router on 5.0.10 withUnable to find file "@IbexaPageBuilderBundle/Resources/config/routing_rest.yaml"— the file doesn't exist in any releasedibexa/page-builder. Reported by a Customer, reverted via ibexa/recipes@aeec5db.The change itself is byte-identical to #117:
ibexa/page-builder#569 adds
GET /api/ibexa/v2/page/structure. The bundle declares its routes inResources/config/routing_rest.yamlwithout the API prefix (same convention asibexa/taxonomy,ibexa/calendarand others), so the application has to import that file withprefix: '%ibexa.rest.path_prefix%'.ibexa.page_builder.restimport toconfig/routes/ibexa_page_builder.yamlof every edition recipe shippingibexa/page-builder(experienceandcommerce,5.0and6.0), mirroring the existingibexa.taxonomy.restimport inibexa_taxonomy.yaml.Note
#117 claimed existing installations need this snippet added by hand. The Customer report proved otherwise:
composer recipes:install <edition> --forcere-applies the recipe during upgrade, so existing installations get the import through the regular upgrade flow — as long as this is released together with apage-builderversion shippingrouting_rest.yaml.For QA:
On a fresh 5.0 or 6.0 experience/commerce installation created after this change, with ibexa/page-builder#569 applied:
config/routes/ibexa_page_builder.yamlcontains theibexa.page_builder.restimport.php bin/console debug:routerlistsibexa.page_builder.rest.page_structurewith path/api/ibexa/v2/page/structure.Documentation:
Covered by the page-builder PR. Nothing recipe-specific to add.
🤖 Generated with Claude Code