Skip to content

Added rule to enforce typehints to closure and arrow functions - #7

Merged
ViniTou merged 1 commit into
4.6from
enforce-callable-return
Nov 25, 2025
Merged

ViniTou merged 1 commit into
4.6from
enforce-callable-return

Conversation

@ViniTou

@ViniTou ViniTou commented Oct 22, 2025

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-XXXXX

Description:

for admin-ui 4.6 it reports

 [ERROR] Found 175 errors                                                                                               

For QA:

Documentation:

@ViniTou
ViniTou requested a review from a team October 22, 2025 08:43

@konradoboza konradoboza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@konradoboza
konradoboza requested a review from a team October 22, 2025 09:01
@Steveb-p

Copy link
Copy Markdown
Contributor

@ViniTou

ViniTou commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

@Steveb-p
From what I understood this is something different, it checks types of callable passed, and the checkMissingCallableSignature checks only for phpDoc. What's more it is already set in
https://github.com/ibexa/phpstan/blob/main/phpstan.neon#L6
and dosent work like this rule at all.

@Steveb-p

Copy link
Copy Markdown
Contributor

What's more it is already set in
https://github.com/ibexa/phpstan/blob/main/phpstan.neon#L6
and dosent work like this rule at all.

Note that this ruleset only applies to this repository. It's not "imported" into the ones using this package.

@ViniTou

ViniTou commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

@Steveb-p
I know, still, I was testing it inside that package. Aside from my testing, if it was working as intended same way it should mark fixture files, right?

@ViniTou
ViniTou force-pushed the enforce-callable-return branch from 1632a2b to f598a82 Compare November 20, 2025 12:00
@ViniTou
ViniTou merged commit a8b2d76 into 4.6 Nov 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants