Rename server_version to serverVersion in CI PostgreSQL DATABASE_URL - #30
Closed
ViniTou wants to merge 2 commits into
Closed
Rename server_version to serverVersion in CI PostgreSQL DATABASE_URL#30ViniTou wants to merge 2 commits into
ViniTou wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Doctrine DBAL 4 reads the connection parameter
serverVersion(camelCase). The old snake_caseserver_versionis read by nothing in DBAL 4 / DoctrineBundle, so the CIDATABASE_URLleft the server version empty andAbstractPostgreSQLDriverthrewDoctrine\DBAL\Platforms\Exception\InvalidPlatformVersionduring bootstrap, before any test ran. This renames the query parameter to the one DBAL 4 actually reads.For QA:
N/A — CI-only change, verified by the workflow's own PostgreSQL integration test job.
Documentation:
N/A