IBX-12530: Dropped the dead getSchemaFiles() override - #37
Merged
Conversation
Since ibexa/test-core#43, DatabaseSchemaHook builds the schema from SchemaBuilderEvent rather than from a file list, and this package already contributes its schema.yaml to that event through its own BuildSchemaSubscriber. The override also re-listed @IbexaCoreBundle's legacy schema.yaml, which parent::getSchemaFiles() already yields. Nothing calls self::loadSchema() here. Verified 10 tests / 41 assertions, unchanged. getSchemaFiles() is deprecated by ibexa/core#823 and ibexa/test-core#47.
tbialcz
approved these changes
Sep 10, 2026
konradoboza
approved these changes
Sep 10, 2026
alongosz
approved these changes
Sep 10, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
DatabaseSchemaHookontoSchemaBuilderEventgetSchemaFiles()Description:
Cleanup found while auditing which packages still touch the schema-file API after
ibexa/test-core#43.
DatabaseSchemaHooknow builds the schema fromSchemaBuilderEventinstead of a file list, andthis package already contributes its
schema.yamlto that event through its ownBuildSchemaSubscriber— so the override had no remaining effect. It is removed.The override also re-listed
@IbexaCoreBundle's legacyschema.yaml, whichparent::getSchemaFiles()already yields — so that entry was redundant even before #43. Nothing here callsself::loadSchema().For QA:
composer test-integrationagainst mergedibexa/test-core4.6.x-dev, same checkout:PHPStan and code style clean.