IBX-12654: Added ibexa/phpstan and fixed dynamic calls to static methods

composer.json

@@ -40,6 +40,7 @@
         "ibexa/doctrine-schema": "~6.0.x-dev",
         "ibexa/http-cache": "~6.0.x-dev",
         "ibexa/notifications": "~6.0.x-dev",
+        "ibexa/phpstan": "~6.0.x-dev",
         "ibexa/rector": "~6.0.x-dev",
         "ibexa/search": "~6.0.x-dev",
         "ibexa/twig-components": "~6.0.x-dev",

phpstan.neon

@@ -2,6 +2,7 @@ includes:
     - phpstan-baseline.neon
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-symfony/extension.neon
+    - vendor/ibexa/phpstan/extension.neon
 
 parameters:
     level: 8

src/lib/DataLoader/SearchContentLoader.php

@@ -39,7 +39,7 @@ public function __construct(SearchService $searchService)
     public function find(Query $query): array
     {
         return array_map(
-            static function (SearchHit $searchHit) {
+            static function (SearchHit $searchHit): Content {
                 return $searchHit->valueObject;
             },
             $this->searchService->findContent($query)->searchHits

src/lib/DataLoader/SearchLocationLoader.php

@@ -46,7 +46,7 @@ public function __construct(SearchService $searchService, LocationService $locat
     public function find(LocationQuery $query): array
     {
         return array_map(
-            static function (SearchHit $searchHit) {
+            static function (SearchHit $searchHit): Location {
                 return $searchHit->valueObject;
             },
             $this->searchService->findLocations($query)->searchHits

src/lib/InputMapper/SearchQueryMapper.php

@@ -81,7 +81,7 @@ private function mapInput(LocationQuery|Query $query, array $inputArray): void
                 $criteria = array_merge(
                     $criteria,
                     array_map(
-                        function ($input) {
+                        function ($input): Field {
                             return $this->mapInputToFieldCriterion($input);
                         },
                         $inputArray['Field']

src/lib/Relay/SearchResolver.php

@@ -8,6 +8,7 @@
 namespace Ibexa\GraphQL\Relay;
 
 use Ibexa\Contracts\Core\Repository\SearchService;
+use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo;
 use Ibexa\Contracts\Core\Repository\Values\Content\Query;
 use Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchHit;
 use Overblog\GraphQLBundle\Relay\Connection\ConnectionBuilder;
@@ -62,7 +63,7 @@ public function searchContent(array $args): ConnectionInterface
         $searchResult = $this->searchService->findContentInfo($query);
 
         $contentItems = array_map(
-            static function (SearchHit $hit) {
+            static function (SearchHit $hit): ContentInfo {
                 return $hit->valueObject;
             },
             $searchResult->searchHits

src/lib/Resolver/ContentResolver.php

@@ -47,7 +47,7 @@ public function findContentByType($contentTypeId): array
         );
 
         return array_map(
-            static function (SearchHit $searchHit) {
+            static function (SearchHit $searchHit): ContentInfo {
                 return $searchHit->valueObject;
             },
             $searchResults->searchHits
@@ -111,7 +111,7 @@ public function resolveContentByIdList(array $contentIdList): array
         }
 
         return array_map(
-            static function (SearchHit $searchHit) {
+            static function (SearchHit $searchHit): ContentInfo {
                 return $searchHit->valueObject;
             },
             $searchResults->searchHits

src/lib/Resolver/DomainContentResolver.php

@@ -142,7 +142,7 @@ public function resolveDomainRelationFieldValue(?Field $field, $multiple = false
 
         if ($multiple) {
             return array_map(
-                static function ($contentId) use ($contentItems) {
+                static function ($contentId) use ($contentItems): Content {
                     return $contentItems[array_search($contentId, array_column($contentItems, 'id'))];
                 },
                 $destinationContentIds

src/lib/Resolver/ItemResolver.php

@@ -136,7 +136,7 @@ public function resolveItemsOfTypeAsConnection(string $contentTypeIdentifier, Ar
             $query->limit = $limit ?? 10;
 
             return array_map(
-                function (Content $content) {
+                function (Content $content): Item {
                     return $this->itemFactory->fromContent($content);
                 },
                 $this->contentLoader->find($query)
@@ -145,7 +145,7 @@ function (Content $content) {
 
         return $paginator->auto(
             $args,
-            function () use ($query) {
+            function () use ($query): int {
                 return $this->contentLoader->count($query);
             }
         );

src/lib/Resolver/LocationResolver.php

@@ -90,7 +90,7 @@ public function resolveLocationChildren($locationId, Argument $args): PageAwareC
             'sortClauses' => $sortClauses,
         ]);
 
-        $paginator = new Paginator(function ($offset, $limit) use ($query) {
+        $paginator = new Paginator(function ($offset, $limit) use ($query): array {
             $query->offset = $offset;
             $query->limit = $limit ?? self::DEFAULT_LIMIT;
 
@@ -100,7 +100,7 @@ public function resolveLocationChildren($locationId, Argument $args): PageAwareC
         return PageAwareConnection::fromConnection(
             $paginator->auto(
                 $args,
-                function () use ($query) {
+                function () use ($query): int {
                     return $this->locationLoader->count($query);
                 }
             ),

src/lib/Resolver/SearchResolver.php

@@ -64,7 +64,7 @@ public function searchContentOfTypeAsConnection($contentTypeIdentifier, Argument
         $query['sortBy'] = $args['sortBy'];
         $query = $this->queryMapper->mapInputToQuery($query);
 
-        $paginator = new Paginator(function ($offset, $limit) use ($query) {
+        $paginator = new Paginator(function ($offset, $limit) use ($query): array {
             $query->offset = $offset;
             $query->limit = $limit ?? 10;
 
@@ -73,7 +73,7 @@ public function searchContentOfTypeAsConnection($contentTypeIdentifier, Argument
 
         return $paginator->auto(
             $args,
-            function () use ($query) {
+            function () use ($query): int {
                 return $this->contentLoader->count($query);
             }
         );