IBX-12046: Removed Symfony 8 deprecated code usage - #56
Open
ViniTou wants to merge 2 commits into
Open
Conversation
Replaces the deprecated Request::get() call in QueryResultsInjector with explicit attributes/query/request bag lookups for the pagination page parameter, mirroring the pattern used in ibexa/core's IBX-12046 fix.
The per-field page parameter is a query-string parameter of the main request; attributes and the POST body were only consulted because Request::get() did so generically.
|
Steveb-p
approved these changes
Sep 11, 2026
mikadamczyk
approved these changes
Sep 11, 2026
konradoboza
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Removes the only Symfony 8-incompatible usage found in this repository:
Request::get()inQueryResultsInjector::buildResults(), used to read the pagination page number for a query field. Replaced with explicitattributes/query/requestbag lookups via amatchexpression, mirroring the pattern used in ibexa/core's IBX-12046 fix (QueryController/QueryRenderController). No BC break: the method is internal to afinal readonlyclass and the resolution order (route attribute, then query string, then request body) is preserved. No constraints, voters, OptionsResolver nested closures, or other Symfony 8 deprecation patterns from the checklist were found in this repository.For QA:
Exercise a content view rendering a query field with pagination enabled (
EnablePaginationfield setting), and confirm the page parameter (<field>_page) is still honored when passed as a query string parameter or route attribute.Documentation:
N/A — no public API changes.