IBX-12043: Upgraded to Doctrine DBAL 4 - #100
Merged
Merged
Conversation
barw4
approved these changes
Aug 28, 2026
bnowak
approved these changes
Sep 2, 2026
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 09:33
a48e105 to
2b84c41
Compare
ViniTou
changed the title
ViniTou
force-pushed
the
dbal-4-upgrade
branch
from
September 3, 2026 10:57
2b84c41 to
7f65d00
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
ibexa/corepinsdoctrine/dbal, so DBAL 4 arrives here whether or not this package was ported.MigrateLegacyMatrixCommandis the only affected code, and it breaks in two ways that only surface when the command is actually run — which is why nothing failed in CI.Two
select()calls passed an array, where DBAL 4 takes the expressions variadically. Separately, PHPStan found what a text search would not:update()lost its second$aliasparameter. Both call sites passed one and then referred to columns through that alias, so the alias is gone and the column references with it —SET data_int1 = ...rather thanSET attr.data_int1 = .... That form is also the one PostgreSQL accepts, which the aliased version was not.For QA:
php bin/console ibexa:migrate-legacy-matrixagainst a database holding legacy matrix field definitions, on MySQL and PostgreSQL. It should report and convert the same definitions and rows as before.Documentation:
N/A